Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI/test dependency issues #1082

Merged
merged 4 commits into from
Feb 8, 2022
Merged

Fix CI/test dependency issues #1082

merged 4 commits into from
Feb 8, 2022

Conversation

waltjones
Copy link
Contributor

@waltjones waltjones commented Feb 7, 2022 •
edited
Loading

Description of the change

Fix CI dependency issues:

  • rails 5.2 CI, pin sinatra to v2.1.0
  • rails 6.x CI, pin sinatra to v2.1.0
  • use explicit hash syntax in method arguments (kw args compatibility)
  • Remove unused Codacy integration. (Rollbar long ago cancelled its Codacy account.)

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@waltjones waltjones changed the title Fix CI dependency issues Fix CI/test dependency issues Feb 7, 2022
@waltjones waltjones force-pushed the waltjones/dependency-updates branch from 25b0e9d to b6e3dc9 Compare February 7, 2022 21:22
@waltjones waltjones mentioned this pull request Feb 7, 2022
Open
7 tasks
cyrusradfar
cyrusradfar approved these changes Feb 8, 2022
View reviewed changes
Copy link

@cyrusradfar cyrusradfar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

@waltjones waltjones merged commit f8185f2 into master Feb 8, 2022
@waltjones waltjones deleted the waltjones/dependency-updates branch June 27, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyrusradfar cyrusradfar cyrusradfar approved these changes

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waltjones @cyrusradfar