Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI/test dependency issues #1082

Merged
merged 4 commits into from
Feb 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ platforms :rbx do
end

gem 'capistrano', :require => false
gem 'codacy-coverage'
gem 'shoryuken'
gem 'simplecov'
gem 'sucker_punch', '~> 2.0'
Expand Down
1 change: 0 additions & 1 deletion gemfiles/rails30.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ platforms :rbx do
end

gem 'capistrano', :require => false
gem 'codacy-coverage'
gem 'rexml', '<= 3.2.4'
gem 'shoryuken'
gem 'simplecov', '<= 0.17.1'
Expand Down
1 change: 0 additions & 1 deletion gemfiles/rails31.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ platforms :rbx do
end

gem 'capistrano', :require => false
gem 'codacy-coverage'
gem 'rexml', '<= 3.2.4'
gem 'shoryuken'
gem 'simplecov', '<= 0.17.1'
Expand Down
1 change: 0 additions & 1 deletion gemfiles/rails32.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ platforms :rbx do
end

gem 'capistrano', :require => false
gem 'codacy-coverage'
gem 'rexml', '<= 3.2.4'
gem 'shoryuken'
gem 'simplecov', '<= 0.17.1'
Expand Down
1 change: 0 additions & 1 deletion gemfiles/rails40.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ platforms :rbx do
end

gem 'capistrano', :require => false
gem 'codacy-coverage'
gem 'json', '~> 2.0'
gem 'shoryuken'
gem 'simplecov', '<= 0.17.1'
Expand Down
1 change: 0 additions & 1 deletion gemfiles/rails41.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ platforms :rbx do
end

gem 'capistrano', :require => false
gem 'codacy-coverage'
gem 'shoryuken'
gem 'simplecov', '<= 0.17.1'
gem 'sucker_punch', '~> 2.0'
Expand Down
1 change: 0 additions & 1 deletion gemfiles/rails42.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ gem 'sinatra'

gem 'nokogiri', '~> 1.6.0' if Gem::Version.new(RUBY_VERSION) <= Gem::Version.new('2.0')

gem 'codacy-coverage'
gem 'simplecov', '<= 0.17.1'
gem 'sucker_punch', '~> 2.0'
gem 'webmock', :require => false
Expand Down
1 change: 0 additions & 1 deletion gemfiles/rails50.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ platforms :rbx do
end

gem 'capistrano', :require => false
gem 'codacy-coverage'
gem 'simplecov', '<= 0.17.1'
gem 'sucker_punch', '~> 2.0'

Expand Down
1 change: 0 additions & 1 deletion gemfiles/rails51.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ platforms :rbx do
end

gem 'capistrano', :require => false
gem 'codacy-coverage'
gem 'simplecov', '<= 0.17.1'
gem 'sucker_punch', '~> 2.0'

Expand Down
5 changes: 2 additions & 3 deletions gemfiles/rails52.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,9 @@ end

gem 'sucker_punch', '~> 2.0'

# We need last sinatra that uses rack 2.x
gem 'sinatra', :git => 'https://github.com/sinatra/sinatra'
# We need last sinatra that uses rack 2.x and ruby 2.5.x
gem 'sinatra', :git => 'https://github.com/sinatra/sinatra', :tag =>'v2.1.0'

gem 'codacy-coverage'
gem 'database_cleaner'
gem 'delayed_job', :require => false
gem 'generator_spec'
Expand Down
5 changes: 2 additions & 3 deletions gemfiles/rails60.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,9 @@ end

gem 'sucker_punch', '~> 2.0'

# We need last sinatra that uses rack 2.x
gem 'sinatra', :git => 'https://github.com/sinatra/sinatra'
# We need last sinatra that uses rack 2.x and ruby 2.5.x
gem 'sinatra', :git => 'https://github.com/sinatra/sinatra', :tag =>'v2.1.0'

gem 'codacy-coverage'
gem 'database_cleaner'
gem 'delayed_job', '4.1.9', :require => false
gem 'generator_spec'
Expand Down
5 changes: 2 additions & 3 deletions gemfiles/rails61.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,9 @@ end

gem 'sucker_punch', '~> 2.0'

# We need last sinatra that uses rack 2.x
gem 'sinatra', :git => 'https://github.com/sinatra/sinatra'
# We need last sinatra that uses rack 2.x and ruby 2.5.x
gem 'sinatra', :git => 'https://github.com/sinatra/sinatra', :tag =>'v2.1.0'

gem 'codacy-coverage'
gem 'database_cleaner'
gem 'delayed_job', '4.1.9', :require => false
gem 'generator_spec'
Expand Down
2 changes: 1 addition & 1 deletion spec/rollbar/plugins/sidekiq_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
it 'constructs scope from msg' do
allow(rollbar).to receive(:error)
expect(Rollbar).to receive(:scope).with(
:framework => "Sidekiq: #{Sidekiq::VERSION}"
{ :framework => "Sidekiq: #{Sidekiq::VERSION}" }
) { rollbar }

described_class.handle_exception(msg, exception)
Expand Down
4 changes: 2 additions & 2 deletions spec/rollbar_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -1812,9 +1812,9 @@ def backtrace

describe '#use_sidekiq', :if => defined?(Sidekiq) do
it 'should instanciate sidekiq delayer with custom values' do
Rollbar::Delay::Sidekiq.should_receive(:new).with('queue' => 'test_queue')
Rollbar::Delay::Sidekiq.should_receive(:new).with({ 'queue' => 'test_queue' })
config = Rollbar::Configuration.new
config.use_sidekiq 'queue' => 'test_queue'
config.use_sidekiq({ 'queue' => 'test_queue' })
end

it 'should send the payload to sidekiq delayer' do
Expand Down
8 changes: 1 addition & 7 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
@@ -1,19 +1,13 @@
begin
require 'simplecov'
require 'codacy-coverage'

SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
SimpleCov::Formatter::HTMLFormatter,
Codacy::Formatter
SimpleCov::Formatter::HTMLFormatter
]

SimpleCov.start do
add_filter '/spec/'
end

# Skip Codacy when running locally, to display the Simplecov summary in the console
# and write an updated coverage/index.html
Codacy::Reporter.start if Codacy::Formatter.new.send :should_run?
rescue LoadError
# Skip loading
end
Expand Down