Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: data race for for Barrier::Wait() #324

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

BorysTheDev
Copy link
Contributor

@BorysTheDev BorysTheDev commented Oct 19, 2024

cond_.notify_all() accesses unprotected wait_queue, therefore it must be under lock.
The problem was found in https://github.com/dragonflydb/dragonfly/actions/runs/11343555702/job/31546353995?pr=3924#step:12:818

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.44%. Comparing base (d30de86) to head (17c4307).
Report is 100 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
+ Coverage   77.60%   78.44%   +0.83%     
==========================================
  Files         103      108       +5     
  Lines        7824     8558     +734     
==========================================
+ Hits         6072     6713     +641     
- Misses       1752     1845      +93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BorysTheDev BorysTheDev changed the title feat: allow reusing CondVar object during CondVar::notify_all() fix: data race for for Barrier::Wait() Oct 21, 2024
@romange romange merged commit 0829556 into romange:master Oct 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants