This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.
|
This PR is stale because it has been open 14 days with no activity. |
2 tasks
06b8238
to
05adcfa
Compare
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
Can we take #4166 into 12.0.0, is the release window still open? |
Yes, it's great you were able to update the PR. I was about to do the same :) |
Co-authored-by: Victorien ELVINGER <[email protected]> Co-authored-by: Emanuele Stoppa <[email protected]>
…4166) * fix(rome_fs): Allow to ignore patterns to symbolic links (symlinks) * refactor: file_name might be None * document the origin_path argument * update test * fix formatting * update test
* feat: 🎸 init * fix: 🐛 parse error * test: 💍 update more test case * test: 💍 update test case * test: 💍 update error test case * test: 💍 update test case * style: 💄 clippy and fmt * test: 💍 add extra test case * chore: 🤖 conflict resolve * test: 💍 update snapshot * chore: 🤖 update test result * test: 💍 update snapshot * chore: 🤖 update test parser * style: 💄 fmt * test: 💍 update format test snapshot * feat: update parse logic * feat: separate parse_ts_type_parameters and parse_ts_type_parameters_with_modifiers * fix: update test case * feat: update parser * fix: update tests * feat: refactor allow_in_out_modifier arguments * feat: revert unnecessary diff --------- Co-authored-by: IWANABETHATGUY <[email protected]>
@ematipico The new --config-path option needs to be documented as well. I will restore my PR tonight and will let you know. |
6e9adaa
to
21a808f
Compare
Conaclos
reviewed
Mar 15, 2023
5ea8c01
to
5534335
Compare
09373d0
to
425299d
Compare
425299d
to
fdf5f96
Compare
cc7ea88
to
e95384c
Compare
Awesome, you guys rock! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4001
With this release, I'd like to propose new changes to how we track changes in the changelog. Since we don't have a good automated way to track changes, now, when a contributor opens a PR, they should add a new line to the changelog. This will help the project in the long run. I added a new section in the
CONTRIBUTING.md
file. I know that thejest
project does the same.Disclaimer
The contents of the changelog are poorer than the previous one because we don't have the resources to look up the previous PRs and track all the changes. I apologize for that, but I hope people can overlook this for now.
Please feel free to change it or add information if you'd like. I don't have the energies to do so, unfortunately.
Test Plan
Rendered website
Rendered changelog