Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media RSS price tag uses Double for the price amount #372

Closed
vsavicks opened this issue Dec 4, 2017 · 1 comment · Fixed by #508 or #617
Closed

Media RSS price tag uses Double for the price amount #372

vsavicks opened this issue Dec 4, 2017 · 1 comment · Fixed by #508 or #617
Labels
theme: rome-modules type: feature
Milestone
2.0.0

Comments

@vsavicks
Copy link
Contributor

vsavicks commented Dec 4, 2017 •
edited
Loading

Using double type for monetary values can cause rounding error in arithmetic operations, hence a more suitable type is recommended, such an integer, long or java.math.BigDecimal.
@vsavicks
Copy link
Contributor Author

vsavicks commented Dec 4, 2017

A fix based on the java.math.BigDecimal and java.util.Currency is implemented in the pull request #371.

The recently accepted pull request #369 along with the pull request #371 should also close the issue #190 about the incomplete Media RSS support.

@PatrickGotthard PatrickGotthard added this to the 2.0.0 milestone Dec 27, 2021
PatrickGotthard added a commit that referenced this issue Dec 29, 2021
@PatrickGotthard
Fix currency and price in MediaModule
a719a97 
Closes #372
@PatrickGotthard PatrickGotthard mentioned this issue Dec 29, 2021
Merged
PatrickGotthard added a commit that referenced this issue Dec 29, 2021
@PatrickGotthard
Enhance currency and price representation in MediaModule (#508)
d6dd8be 
Closes #372
@PatrickGotthard PatrickGotthard mentioned this issue Feb 15, 2023
Merged
antoniosanct pushed a commit to antoniosanct/rome that referenced this issue Feb 15, 2023
@PatrickGotthard @antoniosanct
Enhance currency and price representation in MediaModule (rometools#508)
b4aac7b 
Closes rometools#372
antoniosanct pushed a commit to antoniosanct/rome that referenced this issue Feb 16, 2023
@PatrickGotthard @antoniosanct
Enhance currency and price representation in MediaModule (rometools#508)
308a6dd 
Closes rometools#372
antoniosanct pushed a commit to antoniosanct/rome that referenced this issue Feb 16, 2023
@PatrickGotthard @antoniosanct
Enhance currency and price representation in MediaModule (rometools#508)
b414242 
Closes rometools#372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
theme: rome-modules type: feature
Projects
None yet
Milestone
2.0.0
3 participants
@mishako @vsavicks @PatrickGotthard