Uses Currency/BigDecimal for the Price tag in Media RSS #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is not backward-compatible. Not sure what to do about it. |
PatrickGotthard
force-pushed
the
master
branch
10 times, most recently
from
26b8e6d to
c56c4a4
Compare
PatrickGotthard
force-pushed
the
master
branch
2 times, most recently
from
2152ca9 to
04c8e79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Price tag in Media RSS module was implemented using a
java.lang.Stringfor the currency andjava.lang.Doublefor the price value, which is not recommended for monetary data (causes rounding error). This fix refactors the Price tag to usejava.util.Currencyfor the currency code (as recommended by the ISO 4217) andjava.math.BigDecimalfor the price value.