Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds edge wells documentation and addresses kelshmo comments #138

Merged
merged 3 commits into from
Jan 12, 2022

Conversation

DimmestP
Copy link
Collaborator

Fixes #132 and #124

  • Adds explicit examples for creating plates with empty edge wells for the create_blank_plate and label_plate_rowcol. I don't think any of the other helper functions can be easily coerced into allowing edge wells (I also dont think we need to change them to enable as user can just create custom plate designs)
  • Adjusts function docs title for create_blank_plate, create_blank_plate_96well, and create_blank_plate_1536well to more explicit "Create a blank plate template as a tibble (with helper functions for common plate sizes)"
  • Leaves "Nice tick labels for logarithmic axes in ggplot2" as title for five helper functions as I think their relationship is explained sufficiently clearly in docs
  • Creates unique functions docs for make_row_names_lc1536 and make_row_names_echo1536
  • Adds links to relevant vignettes in label_plate_rowcol doc
  • Fixes target-id warning in calculate_efficiency example

@DimmestP DimmestP linked an issue Jan 11, 2022 that may be closed by this pull request
5 tasks
@ewallace
Copy link
Collaborator

The code looks good, but checks are failing due to some missing link.

Could you address?

Warning: Missing link or links in documentation object 'create_blank_plate.Rd':
  ‘make_row_names_echo1536’ ‘make_row_names_lc1536’

@ewallace ewallace mentioned this pull request Jan 11, 2022
@DimmestP
Copy link
Collaborator Author

I have added the missing files and solved the merge conflict. Just need @ewallace to review and accept.

@ewallace ewallace self-requested a review January 12, 2022 16:35
Copy link
Collaborator

@ewallace ewallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this pull request, everything is in good shape.

@ewallace ewallace merged commit d26970c into ropensci:main Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for plate setup avoiding edge wells Function documentation from @kelshmo review
2 participants