Skip to content

Commit

Permalink
#135 use relative path instead of absolute full path for write to disk
Browse files Browse the repository at this point in the history
change made in make_http_interaction method within the Cassette class
we were using normalizePath, leading to a full path
which only worked on the machine the test/fixture/file was originally run/created on
no longer normalizing path
  • Loading branch information
sckott committed Mar 23, 2020
1 parent 1a4a936 commit 3c860d6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
5 changes: 3 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Description: Record test suite 'HTTP' requests and replays them during
real 'HTTP' responses on disk in 'cassettes'. Subsequent 'HTTP' requests
matching any previous requests in the same 'cassette' use a cached
'HTTP' response.
Version: 0.5.0.91
Version: 0.5.0.92
Authors@R: c(person("Scott", "Chamberlain", role = c("aut", "cre"),
email = "[email protected]",
comment = c(ORCID="0000-0003-1444-9135")),
Expand All @@ -26,7 +26,7 @@ Roxygen: list(markdown = TRUE)
Imports:
crul (>= 0.8.4),
httr,
webmockr (>= 0.6.0),
webmockr (>= 0.6.0.92),
urltools,
yaml,
R6,
Expand All @@ -42,6 +42,7 @@ Suggests:
crayon,
cli,
curl
Remotes: ropensci/webmockr
RoxygenNote: 7.1.0
X-schema.org-applicationCategory: Web
X-schema.org-keywords: http, https, API, web-services, curl, mock, mocking, http-mocking, testing, testing-tools, tdd
Expand Down
1 change: 0 additions & 1 deletion R/cassette_class.R
Original file line number Diff line number Diff line change
Expand Up @@ -630,7 +630,6 @@ Cassette <- R6::R6Class(
if (is.null(write_disk_path))
stop("if writing to disk, write_disk_path must be given; ",
"see ?vcr_configure")
write_disk_path <- normalizePath(write_disk_path, mustWork=TRUE)
new_file_path <- file.path(write_disk_path, basename(x$content))
}
}
Expand Down

0 comments on commit 3c860d6

Please sign in to comment.