Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

write to disk: record paths relative to the test suite dir? #135

Closed
sckott opened this issue Dec 30, 2019 · 2 comments · Fixed by #166
Closed

write to disk: record paths relative to the test suite dir? #135

sckott opened this issue Dec 30, 2019 · 2 comments · Fixed by #166
Labels
bug
Milestone
v0.5.4

Comments

@sckott
Copy link
Collaborator

sckott commented Dec 30, 2019

realized right now with writing to disk tests, we record the absolute file path - which is fine as long as the tests are run on the same machine/server. but if the same tests are run on a different machine, they will likely fail. no bueno
@sckott sckott added the bug label Dec 30, 2019
@sckott sckott added this to the v0.4.6 milestone Dec 30, 2019
@sckott sckott changed the title write to disk: should maybe always record paths relative to the test suite dir? write to disk: record paths relative to the test suite dir? Dec 30, 2019
@sckott sckott modified the milestones: v0.5, v0.6 Feb 28, 2020
@sckott sckott mentioned this issue Mar 13, 2020
Closed
sckott added a commit that referenced this issue Mar 13, 2020
@sckott
#135 use relative path instead of absolute full path for write to disk
9c32d6f 
change made in make_http_interaction method within the Cassette class
we were using normalizePath, leading to a full path
which only worked on the machine the test/fixture/file was originally run/created on
no longer normalizing path
This was referenced Mar 13, 2020
Closed
Closed
@sckott
Copy link
Collaborator Author

sckott commented Mar 20, 2020

I think we need to enforce when the user sets write_disk_path in vcr_configure() that the path is relative to the fixture/cassette path.

@sckott
Copy link
Collaborator Author

sckott commented Mar 20, 2020

makes sense to do the check within vcr_configure() probably so that we maybe don't need to do those path checks within the rest of the package

@sckott sckott mentioned this issue Mar 23, 2020
Merged
sckott added a commit that referenced this issue Mar 23, 2020
@sckott
#135 use relative path instead of absolute full path for write to disk
3c860d6 
change made in make_http_interaction method within the Cassette class
we were using normalizePath, leading to a full path
which only worked on the machine the test/fixture/file was originally run/created on
no longer normalizing path
@sckott sckott modified the milestones: v0.6, v0.5.4 Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.5.4
Development

Successfully merging a pull request may close this issue.

Write disk relative paths ropensci/vcr
1 participant
@sckott