Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignition ros2 control #1
Ignition ros2 control #1
Changes from 41 commits
a512367
2b68d6f
c85f448
d7d44ec
483a973
33a888b
9f47fe7
622614e
5df52f9
9121427
fa457b6
4b4c188
cb42397
52c5a08
a1d1da8
59baef1
3cd82f9
55dd076
af61b68
57b34fe
d7451ad
d7991fe
a5e0920
7e28cf2
3efa1a9
bfdc61c
24b07f4
117331d
8207420
c917a8c
5a21c7a
6e56564
5f596ec
d50c181
0554ee5
6b8a227
c157354
b834eae
766ccad
054d2b5
a11c0c3
abd6d69
6ce4263
c458ec1
1878091
785cac4
d47b38b
a0ab577
3341771
263a190
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to target the official combinations?
ros2_control
is in GalacticThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is not compatible with Citadel
https://github.com/ignitionrobotics/ign_ros2_control/blob/a1d1da883619613071e0c206f16db10a0a633bc4/ignition_ros2_control/src/ignition_ros2_control_plugin.cpp#L337-L344
@chapulina, is there any way the get the MaxStepSize() in a system plugin ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be backported: gazebosim/gz-sim#536
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking closer at the implementation now, you could consider getting the step size from
UpdateInfo
every iteration.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #4 for how that could work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahcorde , with #4 in, are you planning to update this PR to target Citadel + Foxy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the code supports more combinations now. Can we document them here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we provide something like a link to these interfaces so that users can learn more about them if they'd like?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add instructions for building a workspace with the demos first (including installing dependencies) before users try these commands?