Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup dependencies and update metadata in package.xml #725

Merged
merged 3 commits into from
Feb 26, 2025
Merged

Cleanup dependencies and update metadata in package.xml #725

merged 3 commits into from
Feb 26, 2025

Conversation

christophfroehlich
Copy link
Contributor

I realized that there is a mess with the test dependencies

  • I added missing test_depend like launch_testing, and removed unused ones.
  • I removed duplicates, which were already defined in as exec_depend, see the docs.
  • I reorderd some xmls to satisfy the linter

saikishor
saikishor previously approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@saikishor saikishor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for the cleanup 🙌🏽🙌🏽
As far as I can see, the dependencies look fine

@christophfroehlich christophfroehlich changed the title Cleanup dependencies Cleanup dependencies and update metadata in package.xml Feb 26, 2025
saikishor
saikishor approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@christophfroehlich christophfroehlich merged commit d402d69 into master Feb 26, 2025
10 of 11 checks passed
@christophfroehlich christophfroehlich deleted the cleanup/dependencies branch February 26, 2025 13:13
mergify bot pushed a commit that referenced this pull request Feb 26, 2025
@christophfroehlich @mergify
Cleanup dependencies and update metadata in package.xml (#725)
3398ccc 
* Fix dependencies

* Cleanup test_depends

* Update maintainers

(cherry picked from commit d402d69)

# Conflicts:
#	example_1/package.xml
#	example_10/package.xml
#	example_11/package.xml
#	example_12/package.xml
#	example_13/package.xml
#	example_14/package.xml
#	example_15/package.xml
#	example_2/package.xml
#	example_3/package.xml
#	example_4/package.xml
#	example_5/package.xml
#	example_6/package.xml
#	example_7/package.xml
#	example_8/package.xml
#	example_9/package.xml
@mergify mergify bot mentioned this pull request Feb 26, 2025
Merged
christophfroehlich added a commit that referenced this pull request Feb 26, 2025
@christophfroehlich
Cleanup dependencies and update metadata in package.xml (#725)
06a475b
christophfroehlich added a commit that referenced this pull request Feb 26, 2025
@mergify @christophfroehlich
Cleanup dependencies and update metadata in package.xml (#725) (#726)
ace7be9 
Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikishor saikishor saikishor approved these changes

@bmagyar bmagyar Awaiting requested review from bmagyar

@destogl destogl Awaiting requested review from destogl

@LukasMacha97 LukasMacha97 Awaiting requested review from LukasMacha97

@moriarty moriarty Awaiting requested review from moriarty

@peterdavidfagan peterdavidfagan Awaiting requested review from peterdavidfagan

@progtologist progtologist Awaiting requested review from progtologist

@qiayuanl qiayuanl Awaiting requested review from qiayuanl

Assignees
No one assigned
Labels
backport-humble
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophfroehlich @saikishor