Initial OpenEmbedded support for rosdep

[andre-rosa]

• Requires related changes in rospkg and rosdistro
  Initial OpenEmbedded support for rospkg rospkg#166
  Initial OpenEmbedded support for rosdistro ros/rosdistro#20763
• Let us map the generic system dependency name into a recipe name
  available from OE layer index at http://layers.openembedded.org
• Mapping is based on PACKAGE_ARGUMENT free form format of
  package @ meta-layer , where package resides in the OE meta-layer
• Please see the proposal below:
  https://discourse.ros.org/t/a-proposal-for-a-superflore-oe-recipe-generation-scheme/8401

[andre-rosa]

Looks like the CI failure relates to the required dependencies. Please advise on the best way to proceed.

[dirk-thomas]

rospkg 1.1.8 has been released.

This needs an updated version dependency on that rospkg version (in the setup.py as well as stdeb.cfg) since it requires the new API introduced in ros-infrastructure/rospkg#166.

[andre-rosa]

rospkg 1.1.8 has been released.

This needs an updated version dependency on that rospkg version (in the setup.py as well as stdeb.cfg) since it requires the new API introduced in ros-infrastructure/rospkg#166.

Thank you, @dirk-thomas ! I updated rospkg >= 1.1.8 dependency.

[tfoote]

This is failing CI due to the yaml_load deprecation. It's fixed in a follow up commit on this PR: c7a76ef

I think that's reasonable to land soon and then this will work.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@81e72cb). Click here to learn what that means.
The diff coverage is 80%.

@@            Coverage Diff            @@
##             master     #673   +/-   ##
=========================================
  Coverage          ?   75.86%           
=========================================
  Files             ?       32           
  Lines             ?     3016           
  Branches          ?        0           
=========================================
  Hits              ?     2288           
  Misses            ?      728           
  Partials          ?        0

Impacted Files	Coverage Δ
src/rosdep2/__init__.py	78.18% <100%> (ø)
src/rosdep2/platforms/openembedded.py	78.26% <78.26%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81e72cb...b8fe763. Read the comment docs.

[andre-rosa]

This is failing CI due to the yaml_load deprecation. It's fixed in a follow up commit on this PR: c7a76ef

I think that's reasonable to land soon and then this will work.

Cool! I rebased it on top of #675.

[tfoote]

Overall it looks fine. However for future users and developers some pointers to the fact that these functions are not fully impelemented will be important to help people understand what's happening as well as let people know what needs to be implemented to reach full expected functionality.

It would probably be worth putting a comment in the doc block too about these being stubs at the moment, not full implementations.

[andre-rosa]

Overall it looks fine. However, for future users and developers, some pointers to the fact that these functions are not fully implemented will be important to help people understand what's happening as well as let people know what needs to be implemented to reach full expected functionality.

It would probably be worth putting a comment in the doc block too about these being stubs at the moment, not full implementations.

Agree, thanks. I added raising NotImplementedError and left comments for the unimplemented stubs.

[allenh1]

@tfoote Is this one ready to be merged?

[tfoote]

Yes, it's waiting for @wjwwood who's top priority is the Dashing API freeze this week.