Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial OpenEmbedded support for rosdistro #20763

Merged
merged 1 commit into from
May 2, 2019
Merged

Initial OpenEmbedded support for rosdistro #20763

merged 1 commit into from
May 2, 2019

Conversation

andre-rosa
Copy link
Contributor

@andre-rosa andre-rosa commented Mar 30, 2019 •
edited
Loading

@andre-rosa andre-rosa requested a review from a team as a code owner March 30, 2019 18:59
This was referenced Mar 30, 2019
Merged
Merged
Merged
@andre-rosa
Copy link
Contributor Author

Looks like the CI failure relates to the required dependencies. Please advise on the best way to proceed.

tfoote
tfoote requested changes Apr 1, 2019
View reviewed changes
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great to see this coming in to add support for open embedded. I look forward to integrating this. However I'd like to suggest that we consider restructuring how we insert this to keep it more compact and maintainable.

rosdep/oe-opkg.yaml Outdated Show resolved Hide resolved
rosdep/sources.list.d/20-default.list Outdated Show resolved Hide resolved
rosdep/oe-opkg.yaml Outdated Show resolved Hide resolved
rosdep/oe-opkg.yaml Outdated Show resolved Hide resolved
rosdep/oe-opkg.yaml Outdated Show resolved Hide resolved
rosdep/oe-opkg.yaml Outdated Show resolved Hide resolved
rosdep/oe-opkg.yaml Outdated Show resolved Hide resolved
rosdep/oe-opkg.yaml Outdated Show resolved Hide resolved
rosdep/oe-opkg.yaml Outdated Show resolved Hide resolved
@andre-rosa andre-rosa force-pushed the initial_openembedded_support branch from ba0ea88 to 05aa348 Compare April 2, 2019 01:08
tfoote
tfoote approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks with the update it looks good to me.

This can probably be landed independently/ahead of the other related PRs.

@andre-rosa andre-rosa force-pushed the initial_openembedded_support branch 2 times, most recently from 95d0540 to ad3294b Compare April 3, 2019 19:35
cottsay
cottsay approved these changes Apr 3, 2019
View reviewed changes
Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can probably be landed independently/ahead of the other related PRs.

Makes sense to me.

@cottsay
Copy link
Member

cottsay commented Apr 3, 2019

@andre-rosa, looks like you're still tweaking things. Let us know when you believe this is ready to go in.

@cottsay cottsay added in progress rosdep Issue/PR is for a rosdep key labels Apr 3, 2019
@andre-rosa
Copy link
Contributor Author

andre-rosa commented Apr 3, 2019 •
edited
Loading

@andre-rosa, looks like you're still tweaking things. Let us know when you believe this is ready to go in.

Definitely will do, thanks for your review @tfoote @cottsay!

@andre-rosa andre-rosa force-pushed the initial_openembedded_support branch 3 times, most recently from 5507a87 to 179c91b Compare April 11, 2019 17:20
@andre-rosa andre-rosa force-pushed the initial_openembedded_support branch 3 times, most recently from 42f024e to 8d8a28f Compare April 19, 2019 22:55
@andre-rosa andre-rosa force-pushed the initial_openembedded_support branch 8 times, most recently from 47c23a8 to 584c3cd Compare April 26, 2019 00:29
@allenh1
Copy link
Contributor

allenh1 commented Apr 29, 2019

@andre-rosa How far along is this PR? Is it ready for re-review?

@andre-rosa andre-rosa force-pushed the initial_openembedded_support branch from 584c3cd to 7f007ab Compare April 30, 2019 17:51
@andre-rosa
Copy link
Contributor Author

andre-rosa commented Apr 30, 2019 •
edited
Loading

@andre-rosa How far along is this PR? Is it ready for re-review?

@allenh1 Currently, these entries support building ROS 2 Crystal for qemux86, qemuarm64 and raspberrypi3.
We will definitely need changes to support ROS 1 Melodic and may need changes to support ROS 2 Dashing.
We could push the current mappings in this PR and start working on another PR to support the other releases.

@andre-rosa andre-rosa force-pushed the initial_openembedded_support branch 4 times, most recently from a4fb097 to 67575d1 Compare April 30, 2019 21:34
@andre-rosa
Initial OpenEmbedded support for rosdistro
c0d1431 
  * Requires related changes in rospkg, rosdep
    ros-infrastructure/rospkg#166
    ros-infrastructure/rosdep#673
  * Let us map the generic system dependency name into a recipe name
    available from OE layer index at http://layers.openembedded.org
  * Mapping is based on PACKAGE_ARGUMENT free form format of
    <package>@<meta-layer>, where <package> resides in the OE <meta-layer>
  * Please see the proposal below:
    https://discourse.ros.org/t/a-proposal-for-a-superflore-oe-recipe-generation-scheme/8401
@andre-rosa andre-rosa force-pushed the initial_openembedded_support branch from 67575d1 to c0d1431 Compare April 30, 2019 21:48
tfoote
tfoote approved these changes May 1, 2019
View reviewed changes
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging these as is for crystal support and then iterating for further support sounds good to me. It will be one less step closer to being able to reproduce things without forks.

@allenh1
Copy link
Contributor

allenh1 commented May 1, 2019

Sounds good to me -- we can improve ROS 1 support and, when dashing gets closer, dashing support in separate PR's.

@tfoote tfoote merged commit 19f91ba into ros:master May 2, 2019
@andre-rosa andre-rosa deleted the initial_openembedded_support branch May 2, 2019 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cottsay cottsay cottsay approved these changes

@tfoote tfoote tfoote approved these changes

Assignees
No one assigned
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andre-rosa @cottsay @allenh1 @tfoote