Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wxpython for ROS noetic #25920

Merged
merged 4 commits into from
Aug 7, 2020
Merged

Add wxpython for ROS noetic #25920

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2cd91eb
Add wxpython for ROS noetic
Timple Jul 24, 2020
2f69767
Create seperate item for python3-wxgtk4.0
Timple Jul 30, 2020
0a5dd20
Added debian, fedora and gentoo entries for python3-wxgtk4.0
Timple Aug 6, 2020
bf3288f
fedory -> fedora
sloretz Aug 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions rosdep/python.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6553,6 +6553,7 @@ wxpython:
artful: [python-wxgtk3.0]
bionic: [python-wxgtk3.0]
cosmic: [python-wxgtk3.0]
focal: [python3-wxgtk4.0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind making a new rosdep key for python3-wxgtk4.0 instead of expanding the wxpython key? REP 151 and the contributing guide say to add new keys for Python 3 dependencies rather than expand old ones.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I didn't see REP 151. I just crawled the file a bit and found similar examples like python-pyudev and python-requests. But I'll update according to the REP this afternoon!

lucid: [python-wxgtk2.8]
maverick: [python-wxgtk2.8]
natty: [python-wxgtk2.8]
Expand Down