Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wxpython for ROS noetic #25920

Merged
merged 4 commits into from
Aug 7, 2020
Merged

Add wxpython for ROS noetic #25920

merged 4 commits into from
Aug 7, 2020

Conversation

Timple
Copy link
Contributor

@Timple Timple commented Jul 24, 2020

@Timple Timple requested a review from a team as a code owner July 24, 2020 10:10
@clalancette clalancette added the rosdep Issue/PR is for a rosdep key label Jul 28, 2020
sloretz
sloretz reviewed Jul 30, 2020
View reviewed changes
rosdep/python.yaml Outdated
@@ -6553,6 +6553,7 @@ wxpython:
artful: [python-wxgtk3.0]
bionic: [python-wxgtk3.0]
cosmic: [python-wxgtk3.0]
focal: [python3-wxgtk4.0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind making a new rosdep key for python3-wxgtk4.0 instead of expanding the wxpython key? REP 151 and the contributing guide say to add new keys for Python 3 dependencies rather than expand old ones.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I didn't see REP 151. I just crawled the file a bit and found similar examples like python-pyudev and python-requests. But I'll update according to the REP this afternoon!

sloretz
sloretz reviewed Aug 5, 2020
View reviewed changes
Copy link
Contributor

@sloretz sloretz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind also adding debian, fedora and gentoo entries to this key?

@Timple
Copy link
Contributor Author

Timple commented Aug 6, 2020

Mind also adding debian, fedora and gentoo entries to this key?

Sure thing! Is there a standard way of working on how to find these keys for the future?

@sloretz
Copy link
Contributor

sloretz commented Aug 6, 2020

Sure thing! Is there a standard way of working on how to find these keys for the future?

Not that I know of. The contributing guide says Ubuntu and Debian are high priority, with fedora and gentoo being nice to have. The Debian and Ubuntu package names are almost always the same. Finding the Fedora and Gentoo packages requires some googling.

@nuclearsandwich nuclearsandwich merged commit 1aeecfc into ros:master Aug 7, 2020
@mikaelarguedas mikaelarguedas mentioned this pull request Aug 16, 2020
Merged
mjcarroll pushed a commit to ros/actionlib that referenced this pull request Aug 21, 2020
@mikaelarguedas
Port actionlib_tools to Python 3 (#169)
2de1868 
Based on #168 and ros/rosdistro#25920
Fixes: #153 and #167

Signed-off-by: Mikael Arguedas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

@sloretz sloretz sloretz approved these changes

Assignees
No one assigned
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Timple @sloretz @nuclearsandwich @clalancette