Cast double to float #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
reviewed
Nov 14, 2018
|
@clalancette rebuilding with the same packaging job that showed the warnings in the first place |
|
what about using |
|
I'm also setting up an appveyor build for urdfdom so we should get more frequent windows CI testing
Once I have the build working, I'll make a PR and ask @tfoote to add the appveyor webhook |
|
@sloretz it looks like there's still warnings in that CI build? |
|
Ah ooops, I ran CI using urdfdom_headers from master. I'll re-run CI |
|
CI using correct branch |
|
@sloretz that build failed |
|
The build failure should be fixed by ament/ament_lint#115 New CI |
scpeters
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix a warning on windows. See comment https://github.com/ros/urdfdom_headers/pull/47/files#r233640215