Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cast to std::array #321

Merged
merged 3 commits into from
Nov 15, 2018
Merged

cast to std::array #321

merged 3 commits into from
Nov 15, 2018

Conversation

Karsten1987
Copy link
Contributor

fixes #320

I wanted to apply the same style as for the vector in the line below, but cpplint did not like it. It complains something like (error: returnLocalVariable) Pointer to local array variable returned.
Don't know why this doesn't occur with the vector.

@Karsten1987 Karsten1987 added the in review Waiting for review (Kanban column) label Nov 14, 2018
@Karsten1987 Karsten1987 self-assigned this Nov 14, 2018
@Karsten1987
Copy link
Contributor Author

Build Status
Build Status
Build Status
Build Status

@Karsten1987
Copy link
Contributor Author

new CI:

Build Status
Build Status
Build Status
Build Status

@Karsten1987
Copy link
Contributor Author

the unstable on windows is unrelated to this change, see: ros/urdfdom_headers#48

@Karsten1987 Karsten1987 merged commit 82382e8 into master Nov 15, 2018
@Karsten1987 Karsten1987 removed the in review Waiting for review (Kanban column) label Nov 15, 2018
@Karsten1987 Karsten1987 deleted the cast_to_array branch November 15, 2018 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rosidl_typesupport_introspection_cpp potentially unsafe
2 participants