fix encoding handling when writing to stdout and log files #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
added
bug
This was referenced Jul 19, 2019
|
With these fixes in launch the build succeeds but fails the pub/sub tests as well as results in invalid tokens in the xUnit result file: |
dirk-thomas
force-pushed
the
dirk-thomas/bom-generated-code
branch
from
af6ac3a to
0754d76
Compare
|
The latest state of this patch passed the test execution without encode/decode exceptions: |
hidmic
reviewed
Jul 22, 2019
Signed-off-by: Dirk Thomas <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]>
dirk-thomas
force-pushed
the
dirk-thomas/bom-generated-code
branch
from
3d44899 to
649ac7a
Compare
piraka9011
pushed a commit
to aws-ros-dev/launch
that referenced
this pull request
Aug 16, 2019
* fix output encoding of logs to be utf-8 Signed-off-by: Dirk Thomas <[email protected]> * ensure to write to stdout log handler in a supported encoding Signed-off-by: Dirk Thomas <[email protected]> * replace instead of strict Signed-off-by: Dirk Thomas <[email protected]> * replace not needed during decode Signed-off-by: Dirk Thomas <[email protected]> * pass preferred encoding to decode() Signed-off-by: Dirk Thomas <[email protected]> * consistent API Signed-off-by: Dirk Thomas <[email protected]> * fix style Signed-off-by: Dirk Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ros2/rosidl#388.