-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix condition to not skip FastRTPS to FastRTPS pub/sub tests #377
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the logic makes sense as-is with the EQUAL
, but in this scenario (XOR?) I'd expect (A OR B) AND NOT (A AND B)
.
d482770
to
5ce5f12
Compare
The XOR can be expresses as Just using
The additional condition |
This current patch successfully re-enables the FastRTPS-to-FastRTPS tests: see https://ci.ros2.org/job/ci_windows/7441/ (the build failed since it also uses ros2/test_interface_files#8). |
With the tests enabled the build fails (https://ci.ros2.org/job/ci_windows/7441/) due to a bug in launch: ros2/launch#280. |
Signed-off-by: Dirk Thomas <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]>
ff60880
to
facb800
Compare
Signed-off-by: Dirk Thomas <[email protected]>
5d100b6
to
49cdb2f
Compare
Fix regression from #322.
Before: https://ci.ros2.org/job/ci_windows/7438/testReport/(root)/test_communication/
After: https://ci.ros2.org/job/ci_windows/7439/testReport/(root)/test_communication/