Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature of wait for message (#953). #960

Merged
merged 7 commits into from
Nov 16, 2022
Merged

Add feature of wait for message (#953). #960

merged 7 commits into from
Nov 16, 2022

Conversation

llapx
Copy link
Contributor

@llapx llapx commented Jun 22, 2022

Add feature of wait for message.

@llapx llapx mentioned this pull request Jun 22, 2022
Closed
Barry-Xu-2018
Barry-Xu-2018 reviewed Jun 27, 2022
View reviewed changes
Barry-Xu-2018
Barry-Xu-2018 reviewed Jun 28, 2022
View reviewed changes
@audrow audrow changed the base branch from master to rolling June 28, 2022 14:21
fujitatomoya
fujitatomoya reviewed Aug 22, 2022
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments for doc section.

Note: this has the same problem with ros2/rclcpp#1953 (comment)

@fujitatomoya
Copy link
Collaborator

Note: this has the same problem with ros2/rclcpp#1953 (comment)

even though, this will provide the same function to rclpy. i will start the CI.

@fujitatomoya
Copy link
Collaborator

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator

either @ivanpauno or @sloretz can you take a look at this?

@Flova
Copy link
Contributor

Flova commented Nov 12, 2022

Any updates on this?

@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Nov 13, 2022 •
edited
Loading

even with constraint of ros2/rclcpp#1953 (comment), i think this would be worth to add to rclpy atm.

@fujitatomoya
Copy link
Collaborator

@llapx test for this new feature is failing, could you check?

@llapx
Copy link
Contributor Author

llapx commented Nov 14, 2022

@llapx test for this new feature is failing, could you check?

OK, I'll take a check.

@llapx
Copy link
Contributor Author

llapx commented Nov 14, 2022

@fujitatomoya

Updated, can you rerun your CI?

@adityapande-1995
Copy link

CI :

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator

@llapx still tests with this PR are flaky, can you address test failure on your local environment?

@llapx
Fix flake8 warnings.
f9bac1f 
Signed-off-by: Lei Liu <[email protected]>
@llapx
Copy link
Contributor Author

llapx commented Nov 15, 2022

@fujitatomoya

Updated!

@adityapande-1995
Copy link

CI rerun :

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

fujitatomoya
fujitatomoya requested changes Nov 15, 2022
View reviewed changes
@fujitatomoya
Copy link
Collaborator

@llapx sorry, copyright should be adjusted. we do not need to rerun the CI against this change.

@llapx
Update copyright.
8cce267 
Signed-off-by: Lei Liu <[email protected]>
@fujitatomoya
Copy link
Collaborator

@adityapande-1995 can you do another review?

CC: @ivanpauno @clalancette

adityapande-1995
adityapande-1995 approved these changes Nov 16, 2022
View reviewed changes
Copy link

@adityapande-1995 adityapande-1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@fujitatomoya fujitatomoya merged commit c7feb4b into ros2:rolling Nov 16, 2022
fujitatomoya pushed a commit to fujitatomoya/rclpy that referenced this pull request Apr 21, 2024
@llapx @fujitatomoya
Add feature of wait for message (ros2#953). (ros2#960)
0d6b00f 
* Add feature of wait for message.

Signed-off-by: Lei Liu <[email protected]>
Signed-off-by: Tomoya Fujita <[email protected]>
@fujitatomoya fujitatomoya mentioned this pull request Apr 21, 2024
Merged
fujitatomoya added a commit that referenced this pull request Jun 25, 2024
@fujitatomoya @llapx
@KKSTB @Timple
Support wait for message backport humble (#1272)
3ed7868 
* Add feature of wait for message (#953). (#960)

* Add feature of wait for message.

Signed-off-by: Lei Liu <[email protected]>
Signed-off-by: Tomoya Fujita <[email protected]>

* Fix to issue #1179 (#1180)

* Fix to issue #1179

Signed-off-by: KKSTB <[email protected]>
Signed-off-by: Tomoya Fujita <[email protected]>

* Allow specifying qos (#1225)

* Allow specifying qos

Signed-off-by: Tim Clephas <[email protected]>

---------

Signed-off-by: Lei Liu <[email protected]>
Signed-off-by: Tomoya Fujita <[email protected]>
Signed-off-by: KKSTB <[email protected]>
Signed-off-by: Tim Clephas <[email protected]>
Co-authored-by: Lei Liu <[email protected]>
Co-authored-by: KKSTB <[email protected]>
Co-authored-by: Tim Clephas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Barry-Xu-2018 Barry-Xu-2018 Barry-Xu-2018 left review comments

@adityapande-1995 adityapande-1995 adityapande-1995 approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@sloretz sloretz Awaiting requested review from sloretz

Assignees

@adityapande-1995 adityapande-1995

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@llapx @fujitatomoya @Flova @adityapande-1995 @Barry-Xu-2018