This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
update patches for Connext 6, ignore pedantic warning #351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the trivial parts of the patches to apply to the code generated by Connext 6. The patch file
connext_static_serialized_dataPlugin.cxx.patch
contains the heavy lifting and still needs to be updated.@Karsten1987 since you wrote these patches can you please take a look and add commits to this branch to make this work with Connext 6. The goal is to just make this work with the latest release of Connext - not change the way this is being done.
(It seems that the current logic applying the patches doesn't check if they apply cleanly and applies them anyway. So instead of failing when trying it with Connext 6 the patch files are applied even though the context doesn't match the actual files. Then it fails to compile the patched code since the content of the patched files doesn't make any sense. It would be nice if the logic which actually check that the patches apply cleanly - but that doesn't have to be par of this PR.)