This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
update logic / patches to optionally support Connext 6 #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dirk Thomas <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]>
dirk-thomas
added
enhancement
|
CI builds using only Connext 5:
Please see #371 (comment) for a set of master builds acting as a base line. |
This was referenced Oct 16, 2019
Closed
hidmic
reviewed
Oct 16, 2019
rmw_connext_cpp/resources/patch_files_v6/connext_static_serialized_dataSupport.cxx.patch
Show resolved
Hide resolved
rmw_connext_cpp/resources/patch_files_v6/connext_static_serialized_dataSupport.cxx.patch
Show resolved
Hide resolved
There won't be any Connext 6 CI builds at this time. |
Oh, that's unfortunate :( |
hidmic
approved these changes
Oct 17, 2019
Can you enumerate which ones you are referring to? |
|
Compared to an updated master build I don't see differences: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch file
connext_static_serialized_dataPlugin.cxx.patchcontains the heavy lifting and still needs to be updated (some parts present in the v5 patch file have been removed to allow compiling this patch against Connext 6).Though this PR continues to work with Connext 5 and contains all the necessary logic to build with Connext 6 (minus the one remaining patch file to be updated).