-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[foxy] Discriminate when the Client has gone from when the Client has not completely matched #479
Conversation
…mpletely matched Attempt to backport #467 to Foxy in an ABI compatible way. Signed-off-by: Jacob Perron <[email protected]>
@ros-pull-request-builder retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending green CI
…s not completely matched (#479)" This reverts commit c78c31a. Signed-off-by: Shane Loretz <[email protected]>
…s not completely matched (#479)" (#489) This reverts commit c78c31a. Signed-off-by: Shane Loretz <[email protected]>
…not completely matched" (#490) * Revert "Revert "Discriminate when the Client has gone from when the Client has not completely matched (#479)" (#489)" This reverts commit 18483c2. * Use PatchedServicePubListener in rmw_fastrtps_dynamic_cpp Signed-off-by: Jacob Perron <[email protected]>
Hello,
I have Ubuntu 20.04 and up-to-date Foxy packages. Thanks! |
Hello, I also have the same issue on Ubuntu 20.04 and foxy binary. can it be tested again? Thanks!! |
Attempt to backport #467 to Foxy in an ABI compatible way.
I think this is an ABI compatible port; I'll let the ABI checking tell me otherwise.