add --keep-alive option to 'topic pub' #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dirk Thomas <[email protected]>
hidmic
approved these changes
Jun 30, 2020
delete-merged-branch
bot
deleted the
dirk-thomas/ros2topic-pub-keep-alive
branch
craigh92
pushed a commit
to craigh92/ros2cli
that referenced
this pull request
Jul 17, 2020
Signed-off-by: Dirk Thomas <[email protected]> Signed-off-by: Craig Hickman <[email protected]>
sloretz
pushed a commit
that referenced
this pull request
Sep 10, 2020
Signed-off-by: Dirk Thomas <[email protected]> Signed-off-by: Shane Loretz <[email protected]>
sloretz
added a commit
that referenced
this pull request
Sep 10, 2020
…nsient_local and longer keep-alive for pub tests (#546) Use reliable QoS for ros2topic tests (#555) (#565) * add --keep-alive option to 'topic pub' (#544) Signed-off-by: Dirk Thomas <[email protected]> Signed-off-by: Shane Loretz <[email protected]> * Give kwarg default value for backporting keep_alive is made a keyword argument with a default value of 0.1 so the pull request can be backported. Signed-off-by: Shane Loretz<[email protected]> Signed-off-by: Shane Loretz <[email protected]> * use transient_local and longer keep-alive for pub tests (#546) * use transient_local and longer keep-alive for pub tests Signed-off-by: Dirk Thomas <[email protected]> * add comment to document unit of --keep-alive Signed-off-by: Dirk Thomas <[email protected]> Signed-off-by: Shane Loretz <[email protected]> * Use reliable QoS for ros2topic tests (#555) The TestROS2TopicCLI tests perform feature testing of the ros2topic command line interface. If the system is under stress during these tests, messages may be lost (by design). If that happens, there is a fairly high likelihood that the test_topic_pub_once test will fail because there is only one opportunity for the message to be successfully transported. We're likely dropping other messages in this suite, but the other tests continuously publish until one of the messages is received (or a timeout occurs), making them significantly less likely to fail. Using the 'reliable' setting for QoS reliability seems to make the tests consistently pass, even when the system is placed under additional stress. Signed-off-by: Scott K Logan <[email protected]> Signed-off-by: Shane Loretz <[email protected]> Co-authored-by: Dirk Thomas <[email protected]> Co-authored-by: Scott K Logan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new option allows to make the currently hard coded sleep before exiting configurable. It also change the logic to apply that sleep for
times != 1since even when publishing multiple messages it makes sense to wait after the last one to ensure it is published to the wire.CI builds testing
ros2topic: