[Foxy backport] add --keep-alive option to 'topic pub' (#544) use transient_local and longer keep-alive for pub tests (#546) Use reliable QoS for ros2topic tests (#555) #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dirk Thomas <[email protected]> Signed-off-by: Shane Loretz <[email protected]>
keep_alive is made a keyword argument with a default value of 0.1 so the pull request can be backported. Signed-off-by: Shane Loretz<[email protected]> Signed-off-by: Shane Loretz <[email protected]>
* use transient_local and longer keep-alive for pub tests Signed-off-by: Dirk Thomas <[email protected]> * add comment to document unit of --keep-alive Signed-off-by: Dirk Thomas <[email protected]> Signed-off-by: Shane Loretz <[email protected]>
The TestROS2TopicCLI tests perform feature testing of the ros2topic command line interface. If the system is under stress during these tests, messages may be lost (by design). If that happens, there is a fairly high likelihood that the test_topic_pub_once test will fail because there is only one opportunity for the message to be successfully transported. We're likely dropping other messages in this suite, but the other tests continuously publish until one of the messages is received (or a timeout occurs), making them significantly less likely to fail. Using the 'reliable' setting for QoS reliability seems to make the tests consistently pass, even when the system is placed under additional stress. Signed-off-by: Scott K Logan <[email protected]> Signed-off-by: Shane Loretz <[email protected]>
|
CI (Foxy repos file, build:
|
|
CI again, but this time with the ROS distro set to Foxy to take advantage of ros-infrastructure/ros_buildfarm#836
|
cottsay
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #544 which added a new
--keep-aliveflag toros2 topic pubAdds a commit that makes a new argument in #544 a keyword argument with a default value so it doesn't break API
Backports #546 which made
test_topic_pub_onceuse new flagBackports #555 which made
test_topic_pub_onceuse reliable QoSThis should fix the flaky test
test_topic_pub_oncein Foxy CI http://build.ros2.org/job/Fci__nightly-fastrtps-dynamic_ubuntu_focal_amd64/181/testReport/junit/ros2topic.test/test_cli/test_cli/