Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ros2 bag info #15

Closed
Karsten1987 opened this issue Jul 30, 2018 · 0 comments
Closed

Implement ros2 bag info #15

Karsten1987 opened this issue Jul 30, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@Karsten1987
Copy link
Collaborator

Options are:

  • ros2 bag info <bag_file> --> shows info about the bag file

This info shall be similar to the existing ROS 1 info:

$ rosbag info foo.bag
path:        foo.bag
version:     2.0
duration:    1.2s
start:       Jun 17 2010 14:24:58.83 (1276809898.83)
end:         Jun 17 2010 14:25:00.01 (1276809900.01)
size:        14.2 KB
messages:    119
compression: none [1/1 chunks]
types:       geometry_msgs/Point [4a842b65f413084dc2b10fb484ea7f17]
topics:      /points   119 msgs @ 100.0 Hz : geometry_msgs/Point
@Karsten1987 Karsten1987 mentioned this issue Jul 30, 2018
Closed
4 tasks
@sloretz sloretz added the enhancement New feature or request label Aug 1, 2018
agalbachicar added a commit to agalbachicar/rosbag2 that referenced this issue Mar 22, 2022
@agalbachicar
Second round of comments from ros2#960 upstream (ros2#15)
f71ea9c 
* Removes duration parameter. A leftover after switching to playback_duration.

* Fixes comment.

* Solves format in rosbag2_py -> _transport.cpp

* Applies style suggestions.

* Changes play() to return a boolean indicating whether the request could be fulfilled.

* Removes extra unnecessary code.
agalbachicar added a commit to agalbachicar/rosbag2 that referenced this issue Apr 25, 2022
@agalbachicar @gbiggs
Second round of comments from ros2#960 upstream (ros2#15)
5a20233 
* Removes duration parameter. A leftover after switching to playback_duration.

* Fixes comment.

* Solves format in rosbag2_py -> _transport.cpp

* Applies style suggestions.

* Changes play() to return a boolean indicating whether the request could be fulfilled.

* Removes extra unnecessary code.

Signed-off-by: Geoffrey Biggs <[email protected]>
MichaelOrlov added a commit that referenced this issue Jun 2, 2022
@gbiggs @agalbachicar @MichaelOrlov
Add play-for functionality (#960)
ccafe85 
* Add play-for functionality

Signed-off-by: Geoffrey Biggs <[email protected]>

* Add play-for to the CLI

Signed-off-by: Geoffrey Biggs <[email protected]>

* Solves most of the comments from https://github.com/ros2/rosbag2/pull/960/files (#14)

* Add play-for functionality

Signed-off-by: Geoffrey Biggs <[email protected]>

* Add play-for to the CLI

Signed-off-by: Geoffrey Biggs <[email protected]>

* Adds playback_duration to PlayOptions.

* Changes from PlayFor to Play srv message and changes start_offset and playback_duration.

* Restores play_for tests.

* Removes extra SubscriptionManager methods.

* Solves comment about extra sent message.

* Reorders code and comment.

* Removes the SKIP_TEST flag.

Co-authored-by: Geoffrey Biggs <[email protected]>
Signed-off-by: Geoffrey Biggs <[email protected]>

* Second round of comments from #960 upstream (#15)

* Removes duration parameter. A leftover after switching to playback_duration.

* Fixes comment.

* Solves format in rosbag2_py -> _transport.cpp

* Applies style suggestions.

* Changes play() to return a boolean indicating whether the request could be fulfilled.

* Removes extra unnecessary code.

Signed-off-by: Geoffrey Biggs <[email protected]>

* Updates test execution time for #960 (#16)

* Adresses reviewer's comments.

* Improve test time by adding an optional argument to SubscriptionManager::spin_subscriptions()

- Reduces test_play_for execution time from 50s to 6s approximately.

Signed-off-by: Geoffrey Biggs <[email protected]>

* Redesign tests in test_play_for.cpp (#17)

* Redesigned tests to be more deterministic and running faster
* Fixed bug in `play_for()` flow when replaying in loop or multiple
times from the same player instance.

Signed-off-by: Michael Orlov <[email protected]>
Signed-off-by: Geoffrey Biggs <[email protected]>

* Remove unnecessary source file from test binary

Signed-off-by: Geoffrey Biggs <[email protected]>

* Correct errors introduced by rebase

Signed-off-by: Geoffrey Biggs <[email protected]>

* Correct play_next behaviour

Signed-off-by: Geoffrey Biggs <[email protected]>

Co-authored-by: Agustin Alba Chicar <[email protected]>
Co-authored-by: Michael Orlov <[email protected]>
james-rms pushed a commit to james-rms/rosbag2 that referenced this issue Nov 17, 2022
@wep21 @james-rms
chore: refine package.xml (ros2#15)
537d28c 
Signed-off-by: wep21 <[email protected]>
james-rms pushed a commit to james-rms/rosbag2 that referenced this issue Nov 17, 2022
@wep21 @james-rms
chore: refine package.xml (ros2#15)
b22fa2d 
Signed-off-by: wep21 <[email protected]>
Signed-off-by: James Smith <[email protected]>
emersonknapp added a commit that referenced this issue May 14, 2024
@emersonknapp
[backport fumble] Datetime file suffix for split bags [ENG-1929] (#15) (
07a02fe 
#18)

* Datetime file suffix for split bags [ENG-1929] (#15)
* Provide option to put a datetime file suffix on split bag files, in place of an increasing index

Signed-off-by: Emerson Knapp <[email protected]>
@userguide-galaxea userguide-galaxea mentioned this issue Nov 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sloretz @Karsten1987