Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert ROS 1 binary data to ROS 2 #17

Closed
Karsten1987 opened this issue Jul 30, 2018 · 1 comment
Closed

Convert ROS 1 binary data to ROS 2 #17

Karsten1987 opened this issue Jul 30, 2018 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@Karsten1987
Copy link
Collaborator

Connects to #11
With the help of the ROS 1 bridge there shall be a convert function which converts ROS 1 binary data into a ROS 2 message.
@Karsten1987 Karsten1987 added the help wanted Extra attention is needed label Jul 30, 2018
@Karsten1987
Copy link
Collaborator Author

@sriramster fyi

@Martin-Idel-SI Martin-Idel-SI mentioned this issue Nov 5, 2018
Closed
anhosi pushed a commit to bosch-io/rosbag2 that referenced this issue Nov 26, 2018
@Martin-Idel-SI @anhosi
ros2GH-17 Add leak sanitizer to test
304d8a7 
- one of the main test goals can only be ssen by valgrind or sanitizers
- enable leak sanitizer for gcc builds only (for now)
anhosi pushed a commit to bosch-io/rosbag2 that referenced this issue Nov 26, 2018
@Martin-Idel-SI @anhosi
ros2GH-17 Rename timestamp to time_stamp for consistency in types
46c643c
anhosi added a commit to bosch-io/rosbag2 that referenced this issue Nov 26, 2018
@anhosi
ros2GH-17 Allow disabling the usage of sanitizers
e479b2b 
This allows manual usage of valgrind.
Martin-Idel-SI added a commit to bosch-io/rosbag2 that referenced this issue Nov 26, 2018
@Martin-Idel-SI
ros2GH-17 Rename timestamp to time_stamp for consistency in types
caa0ae6
Martin-Idel-SI added a commit to bosch-io/rosbag2 that referenced this issue Nov 26, 2018
@Martin-Idel-SI
ros2GH-17 Add leak sanitizer to test
6ff0836 
- one of the main test goals can only be ssen by valgrind or sanitizers
- enable leak sanitizer for gcc builds only (for now)
Martin-Idel-SI pushed a commit to bosch-io/rosbag2 that referenced this issue Nov 26, 2018
@anhosi @Martin-Idel-SI
ros2GH-17 Allow disabling the usage of sanitizers
4e5b51a 
This allows manual usage of valgrind.
Martin-Idel-SI added a commit to bosch-io/rosbag2 that referenced this issue Nov 26, 2018
@Martin-Idel-SI
ros2GH-17 Fix renaming after rebase
f0eb3ab
Karsten1987 pushed a commit that referenced this issue Nov 26, 2018
@Martin-Idel-SI @Karsten1987
Renaming struct members for consistency (#64)
149e85b 
* GH-118 Rename rosbag2_storage::TopicMetadata to TopicInformation and rosbag2_storage::TopicwithType to TopicMetadata

- The former TopicWithTye struct will be enlarged to contain also the rmw serialization format relative to the topic. This is why the name 'TopicMetadata' is now better suited for it.

* GH-17 Rename timestamp to time_stamp for consistency in types

* Fix renaming of TopicWithType to TopicMetadata

* formatting

* pass by const ref
anhosi pushed a commit to bosch-io/rosbag2 that referenced this issue Nov 27, 2018
@Martin-Idel-SI @anhosi
ros2GH-17 Add leak sanitizer to test
605a15f 
- one of the main test goals can only be ssen by valgrind or sanitizers
- enable leak sanitizer for gcc builds only (for now)
anhosi added a commit to bosch-io/rosbag2 that referenced this issue Nov 27, 2018
@anhosi
ros2GH-17 Allow disabling the usage of sanitizers
5a93f1b 
This allows manual usage of valgrind.
anhosi pushed a commit to bosch-io/rosbag2 that referenced this issue Nov 27, 2018
@Martin-Idel-SI @anhosi
ros2GH-17 Fix renaming after rebase
aa73556
anhosi added a commit to bosch-io/rosbag2 that referenced this issue Nov 28, 2018
@anhosi
ros2GH-17 Small cleanups (addressing review comments)
77608b5
Karsten1987 pushed a commit that referenced this issue Nov 29, 2018
@botteroa-si @Karsten1987
Use converters when recording a bag file (#57)
30c4733 
* GH-118 Make rosbag2::Writer use converters

- Use converters in Writer::write() when input rmw serialization format is different from desired storage serialization format
- Add new field in rosbag2::StorageOptions to keep track of the rmw format given by the user to store the message in

* GH-118 Add --encoding option to ros2 bag record

* GH-118 Associate to each topic its rmw_serialization_format

- Add 'serialization_format' field to TopicMetadata
- Add 'serialization_forat' column in 'topics' table in sqlite storage
- Remove 'storage_format' from BagMetadata and use the TopicMetadata field directly, instead
- the field 'rmw_serialization_format' has been moved from rosbag2::StorageOptions to rosbag2_transport::RecordOptions, because it's a topic property rather than a storage one.
- Currently all topics in a bag file must have the same serialization format
- The tests have been updated accordingly

* GH-118 Fix tests after rebase

* GH-118 Fix MockMetadataIO and use it in test_writer

* GH-118 Fix Windows build and minor refactoring

* GH-118 Add test for writer to check that error is thrown if converter plugin does not exist

* GH-118 Add test to check that metadat_io_ writes metadata file in writer's destructor

* GH-118 Build Converter before opening the database in Writer::open()

- This assures that if one of the converter plugins does not exist, the database is not created

* GH-118 Add end-to-end tests to check graceful failure if converter plugins do not exists

- Both a test for record and play has been added

* GH-118 Rename 'encoding' CLI option to 'serialization_format'

* GH-127 Write serialization format in database also when it's not specified at CLI level

- Tests to check that the serialization format is written in the database have also been added.

* GH-17 Add leak sanitizer to test

- one of the main test goals can only be ssen by valgrind or sanitizers
- enable leak sanitizer for gcc builds only (for now)

* GH-137: Fix cdr converter plugin

- update pluginlib descriptions file after several renames
- fix export of missing includes folder

* GH-137 Add integration test for cdr converter

* GH-137 Fix superfluous printf

* GH-137 It suffices to have only one converter test

* GH-137 Minor refactoring for better readability of test

N.B. This exposes an pre-existing memory leak (not fixed here).

* GH-137 Fix memory leak of topic_name

- topic_name member needs to be freed
- provide a setter for convenience
- Directly assigning a string literal in the test is not sufficient as
  this would be static memory that does not need to be freed.

* GH-17 Allow disabling the usage of sanitizers

This allows manual usage of valgrind.

* GH-17 Fix renaming after rebase

* GH-17 Small cleanups (addressing review comments)
agalbachicar pushed a commit to agalbachicar/rosbag2 that referenced this issue Apr 25, 2022
@MichaelOrlov @gbiggs
Redesign tests in test_play_for.cpp (ros2#17)
46edcdd 
* Redesigned tests to be more deterministic and running faster
* Fixed bug in `play_for()` flow when replaying in loop or multiple
times from the same player instance.

Signed-off-by: Michael Orlov <[email protected]>
Signed-off-by: Geoffrey Biggs <[email protected]>
MichaelOrlov added a commit that referenced this issue Jun 2, 2022
@gbiggs @agalbachicar @MichaelOrlov
Add play-for functionality (#960)
ccafe85 
* Add play-for functionality

Signed-off-by: Geoffrey Biggs <[email protected]>

* Add play-for to the CLI

Signed-off-by: Geoffrey Biggs <[email protected]>

* Solves most of the comments from https://github.com/ros2/rosbag2/pull/960/files (#14)

* Add play-for functionality

Signed-off-by: Geoffrey Biggs <[email protected]>

* Add play-for to the CLI

Signed-off-by: Geoffrey Biggs <[email protected]>

* Adds playback_duration to PlayOptions.

* Changes from PlayFor to Play srv message and changes start_offset and playback_duration.

* Restores play_for tests.

* Removes extra SubscriptionManager methods.

* Solves comment about extra sent message.

* Reorders code and comment.

* Removes the SKIP_TEST flag.

Co-authored-by: Geoffrey Biggs <[email protected]>
Signed-off-by: Geoffrey Biggs <[email protected]>

* Second round of comments from #960 upstream (#15)

* Removes duration parameter. A leftover after switching to playback_duration.

* Fixes comment.

* Solves format in rosbag2_py -> _transport.cpp

* Applies style suggestions.

* Changes play() to return a boolean indicating whether the request could be fulfilled.

* Removes extra unnecessary code.

Signed-off-by: Geoffrey Biggs <[email protected]>

* Updates test execution time for #960 (#16)

* Adresses reviewer's comments.

* Improve test time by adding an optional argument to SubscriptionManager::spin_subscriptions()

- Reduces test_play_for execution time from 50s to 6s approximately.

Signed-off-by: Geoffrey Biggs <[email protected]>

* Redesign tests in test_play_for.cpp (#17)

* Redesigned tests to be more deterministic and running faster
* Fixed bug in `play_for()` flow when replaying in loop or multiple
times from the same player instance.

Signed-off-by: Michael Orlov <[email protected]>
Signed-off-by: Geoffrey Biggs <[email protected]>

* Remove unnecessary source file from test binary

Signed-off-by: Geoffrey Biggs <[email protected]>

* Correct errors introduced by rebase

Signed-off-by: Geoffrey Biggs <[email protected]>

* Correct play_next behaviour

Signed-off-by: Geoffrey Biggs <[email protected]>

Co-authored-by: Agustin Alba Chicar <[email protected]>
Co-authored-by: Michael Orlov <[email protected]>
james-rms pushed a commit to james-rms/rosbag2 that referenced this issue Nov 17, 2022
@jhurliman @james-rms
[1.0.0] Use Summary section for get_metadata() and seek(), implement …
1c4afca 
…remaining methods (ros2#17)

Signed-off-by: John Hurliman <[email protected]>
james-rms pushed a commit to james-rms/rosbag2 that referenced this issue Nov 17, 2022
@jhurliman @james-rms
[1.0.0] Use Summary section for get_metadata() and seek(), implement …
03af72c 
…remaining methods (ros2#17)

Signed-off-by: John Hurliman <[email protected]>
Signed-off-by: James Smith <[email protected]>
@userguide-galaxea userguide-galaxea mentioned this issue Nov 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Karsten1987