Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player and recorder #58

Closed
AnandShastry opened this issue Nov 5, 2018 · 4 comments
Closed

Player and recorder #58

AnandShastry opened this issue Nov 5, 2018 · 4 comments

Comments

@AnandShastry
Copy link

AnandShastry commented Nov 5, 2018 •
edited
Loading

Label-Question:
Do we have player and recorder functionality available to use like in rosbag?
@Martin-Idel-SI
Copy link
Contributor

At the moment, you can only use ros2 bag play, ros2 bag record and ros2 bag info on the CLI. Those and all options they offer should work correctly. The programming interface for rosbag2 does not yet exist (or is very unstable at best).

By design, there will be a C-Interface for rosbag2 (which will reside in the rosbag2 package), but it is not implemented yet.

@AnandShastry
Copy link
Author

thank you..does it have a backward compatibility ? like can it play ros1 bag files

@Martin-Idel-SI
Copy link
Contributor

Martin-Idel-SI commented Nov 5, 2018 •
edited
Loading

Not yet - see #17

@clalancette
Copy link
Contributor

Since this is a question and not an issue, per-se, I'm going to close this out. If you'd like to continue the conversation, it would probably be good to use https://answers.ros.org for this. Thanks!

james-rms pushed a commit to james-rms/rosbag2 that referenced this issue Nov 17, 2022
@MichaelOrlov @james-rms
Some minor improvements in rosbag2_storage_mcap after review (ros2#58)
58badfd 
1. Fixed some findings from Clang-Tidy
1. Some renames according to the ROS2 coding style
1. Add default initializations for member variables
1. Moved code responsible for adding schema and channel from write(msg)
to create_topic(topic) method to reduce performance burden on first
message write and in lieu to preparation for moving schema collection
process to upper SequentialWriter layer.

Signed-off-by: Michael Orlov <[email protected]>

Signed-off-by: Michael Orlov <[email protected]>
james-rms pushed a commit to james-rms/rosbag2 that referenced this issue Nov 17, 2022
@MichaelOrlov @james-rms
Some minor improvements in rosbag2_storage_mcap after review (ros2#58)
f52f278 
1. Fixed some findings from Clang-Tidy
1. Some renames according to the ROS2 coding style
1. Add default initializations for member variables
1. Moved code responsible for adding schema and channel from write(msg)
to create_topic(topic) method to reduce performance burden on first
message write and in lieu to preparation for moving schema collection
process to upper SequentialWriter layer.

Signed-off-by: Michael Orlov <[email protected]>

Signed-off-by: Michael Orlov <[email protected]>
Signed-off-by: James Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@clalancette @AnandShastry @Martin-Idel-SI