Consolidate ZSTD utility functions #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this intended to be a followup, to be merged after #418 ? |
|
Yes. |
|
@pjreed can you please rebase this on master? |
The zstd_compressor and zstd_decompressor implementations had a number of duplicated utility functions between them; this consolidates them into one file. Signed-off-by: P. J. Reed <[email protected]>
pjreed
force-pushed
the
consolidate-zstd-util-functions
branch
from
d40e3df to
da96d1e
Compare
|
Sure, all done. |
rosbag2_compression/src/rosbag2_compression/compression_utils.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: P. J. Reed <[email protected]>
Signed-off-by: P. J. Reed <[email protected]>
emersonknapp
approved these changes
Jul 21, 2020
|
@emersonknapp - please run this CI job |
|
|
Well, there is a single compiler warning on Windows, but it's in a source file you didn't touch, so LGTM |
|
It was from an unused variable that was fixed in #460 |
emersonknapp
pushed a commit
that referenced
this pull request
Feb 2, 2021
* Consolidate ZSTD utility functions The zstd_compressor and zstd_decompressor implementations had a number of duplicated utility functions between them; this consolidates them into one file. Signed-off-by: P. J. Reed <[email protected]>
emersonknapp
pushed a commit
that referenced
this pull request
Feb 17, 2021
* Consolidate ZSTD utility functions The zstd_compressor and zstd_decompressor implementations had a number of duplicated utility functions between them; this consolidates them into one file. Signed-off-by: P. J. Reed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zstd_compressor and zstd_decompressor implementations had a
number of duplicated utility functions between them; this consolidates
them into one file.
Distro A, OPSEC #2893