Zstd should not install internal headers #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thers that aren't installed. We don't use them. Avoid the situation Signed-off-by: Emerson Knapp <[email protected]>
emersonknapp
requested review from
Karsten1987 and
jikawa-az
and removed request for
a team
Karsten1987
approved these changes
Feb 3, 2021
|
Gist: https://gist.githubusercontent.com/emersonknapp/9c3f11e0cb06a13fa752161e443a7e1f/raw/51879af2085d673d53c277f81d9c1cd009108913/ros2.repos
|
jikawa-az
approved these changes
Feb 3, 2021
delete-merged-branch
bot
deleted the
emersonknapp/zstd-no-install-internal-headers
branch
emersonknapp
added a commit
that referenced
this pull request
Feb 12, 2021
…thers that aren't installed. We don't use them. Avoid the situation (#631) Signed-off-by: Emerson Knapp <[email protected]>
emersonknapp
added a commit
that referenced
this pull request
Feb 15, 2021
Signed-off-by: Emerson Knapp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of them try include others that aren't installed. We don't use them. Avoid the situation entirely.
Specific case:
cover.hincludesmem.h, which isn't installed. This causes the ABI/API checkers on PR builds to fail because they can't findmem.h