Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[foxy backport] Zstd should not install internal headers - some of them try include others that aren't installed. We don't use them. Avoid the situation (#631) #653

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

emersonknapp
Copy link
Collaborator

Backport #631 to Foxy

…thers that aren't installed. We don't use them. Avoid the situation (#631)

Signed-off-by: Emerson Knapp <[email protected]>
Copy link
Collaborator

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm given the PR build runs through.
I think technically that's already a breaking change (people might link against the installed headers), but I feel confident to let that slip here.

@emersonknapp
Copy link
Collaborator Author

emersonknapp commented Feb 12, 2021

I think technically that's already a breaking change (people might link against the installed headers)

Yes, I think you're right, but I also feel confident that nobody knows about or uses these headers. As far as I can tell - they wouldn't be able to successfully build against them under normal circumstances, because other headers they try to include are not installed.

@emersonknapp
Copy link
Collaborator Author

@ros-pull-request-builder retest this please

@emersonknapp
Copy link
Collaborator Author

The failure is just the API/ABI checker failing on these Zstd headers - I'll merge this and get a Foxy patch build out for rosbag2 in hopes that we can remedy the situation

@emersonknapp emersonknapp merged commit 759ec27 into foxy Feb 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the emersonknapp/foxy-backport-631 branch February 15, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants