-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function for getting a types fully qualified name #514
Conversation
As opposed the type name 'foo::msg::Bar', the new function let's us get the ROS namespaced name 'foo/msg/Bar'. Signed-off-by: Jacob Perron <[email protected]>
Signed-off-by: Jacob Perron <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, but should we also have just name
? It just seems odd to "reserve" that term by using "fully qualified name" if we're not gonna have it. And if we intend to have it, now would be a good time to add it I guess.
Good suggestion. What do you think about adding three new functions instead?
|
I like The other option is just to have I don't have a strong opinion one way or the other. |
I like this option. I think it's unlikely a user only wants the last part of the name (or just the namespace), and in this case they can do the splitting themselves. |
Signed-off-by: Jacob Perron <[email protected]>
As opposed the type name 'foo::msg::Bar', the new function let's us get the ROS namespaced name 'foo/msg/Bar'.
This seems generally useful, and would simplify logic in ros2/rviz#591 for example.
I'm open to changing the name of the new function if there are better suggestions.