Fast-forward foxy branch #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update QD to reflect QL 2 statuses. Updates rosidl_runtime_cpp and rosidl_typesupport_interface. Signed-off-by: Stephen Brawner <[email protected]> * Update coverage link Signed-off-by: Stephen Brawner <[email protected]> * Adding link to on-boarding guide Signed-off-by: Stephen Brawner <[email protected]> * Remove quotes Signed-off-by: Stephen Brawner <[email protected]> * fix link Signed-off-by: Stephen Brawner <[email protected]>
Signed-off-by: Stephen Brawner <[email protected]>
* Fix misuses of input iterators in BoundedVector Input iterators are single pass, so calling std::distance(first, last) will consume the input and leave [first,last) as an empty range. This change makes assign(InputIterator, InputIterator) and insert(const_iterator, InputIterator, InputIterator) dispatch to overloaded functions that choose the right overload based on the iterator category. For forward iterators the original implementation is used. For input iterators assign will construct a new vector and if that doesn't throw, use swap to replace the contents of *this. For insert each value is inserted at the end and if the bound is not exceeded std::rotate is used to shift them to the desired position, otherwise the inserted elements are removed from the end before the function exits. This retains the strong exception safety guarantee for both operations, so that exceeding the bound does not alter the existing contents of the vector. Fixes #486 Signed-off-by: Jonathan Wakely <[email protected]> * Add test filling BoundedVector from forward iterators Also replace the existing use of a definition using decltype, which was frowned on in the comments of #493. Signed-off-by: Jonathan Wakely <[email protected]> * Fix UB in BoundedVector test. Signed-off-by: Michel Hidalgo <[email protected]> Co-authored-by: Michel Hidalgo <[email protected]>
…isabled (#503) Signed-off-by: Ben Wolsieffer <[email protected]>
* Add pytest.ini so tests succeed locally. Signed-off-by: Chris Lalancette <[email protected]>
* allow zero length string constants Signed-off-by: Dirk Thomas <[email protected]> * update test with empty string constant Signed-off-by: Dirk Thomas <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]>
Signed-off-by: Alex Tyshka <[email protected]>
Resolves issues with older GCC versions, as described in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56480 Resolves #479 Signed-off-by: Sebastian Höffner <[email protected]>
|
Note, there are no test failures. The Fpr job is failing due to an unrelated infrastructure issue. |
|
@ros-pull-request-builder retest this please (using custom job config from ros-infrastructure/ros_buildfarm#828) |
|
@ros-pull-request-builder retest this please (using custom job config from ros-infrastructure/ros_buildfarm#828) - checking for the API/API report... |
As opposed the type name 'foo::msg::Bar', the new function let's us get the ROS namespaced name 'foo/msg/Bar'. Signed-off-by: Jacob Perron <[email protected]>
|
I've also add #514 to backport, though not strictly necessary I thought it would be nice to release once from |
dirk-thomas
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think all code changes, except #493, are marked for backport. I don't see why we shouldn't backport #493 either.