Skip to content

Commit

Permalink
Merge pull request tinkerbell#136 from jacobweinstock/nginx-annotations
Browse files Browse the repository at this point in the history
Add nginx service annotations:

## Description

<!--- Please describe what this PR is going to change -->
Allows customization for things like load balancer.

## Why is this needed

<!--- Link to issue you have raised -->

Fixes: tinkerbell#62 

## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran to -->
<!--- see how your change affects other areas of the code, etc. -->


## How are existing users impacted? What migration steps/scripts do we need?

<!--- Fixes a bug, unblocks installation, removes a component of the stack etc -->
<!--- Requires a DB migration script, etc. -->


## Checklist:

I have:

- [ ] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [ ] provided instructions on how to upgrade
  • Loading branch information
jacobweinstock authored Oct 24, 2024
2 parents d04ab45 + 3ecf2db commit 97f3c5c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
4 changes: 4 additions & 0 deletions tinkerbell/stack/templates/nginx.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,10 @@ metadata:
app: {{ .Values.stack.name }}
name: {{ .Values.stack.name }}
namespace: {{ .Release.Namespace | quote }}
annotations:
{{- with .Values.stack.service.annotations }}
{{- toYaml . | nindent 4 }}
{{- end }}
spec:
type: {{ .Values.stack.service.type }}
{{- if eq .Values.stack.service.type "LoadBalancer" }}
Expand Down
1 change: 1 addition & 0 deletions tinkerbell/stack/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ stack:
service:
enabled: true
type: LoadBalancer
annotations: {}
selector:
app: tink-stack
nodeSelector: {}
Expand Down

0 comments on commit 97f3c5c

Please sign in to comment.