Use latest Rails by default #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest Rails includes ActiveCable tests, that are otherwise skipped when testing compatibility of other RSpec projects, e.g. `rspec-expectation` on CI.
pirj
force-pushed
the
use-latest-rails-by-default-in-specs
branch
from
0f81c37 to
a257ba0
Compare
JonRowe
approved these changes
Jan 23, 2020
JonRowe
reviewed
Jan 23, 2020
| @@ -28,7 +28,7 @@ when /stable/ | |||
| MAJOR = 6 | |||
| MINOR = 0 | |||
| when nil, false, "" | |||
There was a problem hiding this comment.
Slight improvement, you could merge this with above.
benoittgt
approved these changes
Jan 23, 2020
|
This can be merged after rspec/rspec-dev#235 and its child pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest Rails includes ActionCable tests, that are otherwise skipped when testing the compatibility of other RSpec projects, e.g.
rspec-expectationon CI.Related pull request that was expected to fail, but didn't rspec/rspec-expectations#1157
Originally found here rspec/rspec-expectations#1155 (comment)