Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ruby 2.7 to build matrix #2271

Merged
merged 4 commits into from
May 15, 2020
Merged

Add Ruby 2.7 to build matrix #2271

merged 4 commits into from
May 15, 2020

Conversation

pirj
Copy link
Member

@pirj pirj commented Jan 23, 2020

Also, use latest Ruby patch versions

Spec failure is fixed in #2270

@pirj pirj self-assigned this Jan 23, 2020
pirj
pirj commented Jan 23, 2020
View reviewed changes
appveyor.yml
@@ -37,3 +37,4 @@ environment:
- ruby_version: 24-x64
- ruby_version: 25-x64
- ruby_version: 26-x64
- ruby_version: 27-x64
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even run AppVeyor, or can we drop this config?

Copy link
Member

@benoittgt benoittgt Jan 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No no for me we have to keep it. Why would you want to remove it? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem to be configured https://ci.appveyor.com/project/rspec/rspec-rails, and we don't seem to run it (example passed and merged pull request #2267, see View Details).

No objections on keeping it, just wondering why we need it since we've divorced rspec-rails from other RSpec projects, and even updating common Travis files mostly doesn't apply.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes your are right. A little bit of context I think #1218 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification! Let's keep it until someone volunteers to properly add build support.

@pirj pirj requested a review from JonRowe January 24, 2020 13:10
@pirj pirj force-pushed the add-ruby-2.7-to-matrix branch from 0490c6d to f183132 Compare January 24, 2020 13:58
JonRowe
JonRowe approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@JonRowe JonRowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this when it's green :)

@pirj
Copy link
Member Author

pirj commented Jan 24, 2020 •
edited
Loading

😆
Most if not all of this comes from Rails itself, some of the warnings have been fixed, but doesn't seem to be released.

Let's see what I can do with the rest, but in any case, we'll have to wait for another Rails release first.

I'll keep this open as a reminder.

@pirj
Copy link
Member Author

pirj commented Feb 4, 2020 •
edited
Loading

Grepped the following from https://travis-ci.org/rspec/rspec-rails/jobs/641857791 mostly.

  1. Those commits were made before 6.0.2.1 was released, and are on master, but are not part of 6.0.2.1:
    rails/rails@6d68bb5
    rails/rails@2c66870
    rails/rails@3525603
    rails/rails@a9ac7a8
    rails/rails@e1e7fd6
    rails/rails@f42f286
    It makes sense to remind releasers to include those to the next release.

  2. There's a hanging pull request here warning: The last argument is used as the keyword parameter for ruby-2.7 rails/rails-controller-testing#50

  3. actionpack/lib/action_dispatch/middleware/stack.rb needs to be fixed.
    I have sent a rather radical pull request Get rid of Ruby 2.7 keyword argument usage warnings rails/rails#38386

@JonRowe
Copy link
Member

JonRowe commented May 13, 2020 •
edited
Loading

Hey @pirj do you want to update this? I might take a look otherwise...

@pirj
Copy link
Member Author

pirj commented May 14, 2020

On it 👍

pirj
pirj commented May 14, 2020
View reviewed changes
spec/spec_helper.rb
@@ -37,6 +37,10 @@ def self.run_all(reporter=nil)
mocks.verify_doubled_constant_names = true
end

config.expect_with :rspec do |c|
c.max_formatted_output_length = 1000
end
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but very helpful at times, especially in this repo.

@pirj pirj force-pushed the add-ruby-2.7-to-matrix branch 2 times, most recently from 3dee0c9 to db68e5f Compare May 14, 2020 18:19
@benoittgt
Copy link
Member

You could add this 28f9597

@JonRowe
Copy link
Member

JonRowe commented May 15, 2020

Feel free to cherry-pick 1f723f5 from #2332 into this if it gets Ruby 2.7 on the matrix, we'll have to address it seperately I feel

@JonRowe JonRowe merged commit d33432a into master May 15, 2020
@JonRowe JonRowe deleted the add-ruby-2.7-to-matrix branch May 15, 2020 16:22
JonRowe added a commit that referenced this pull request May 16, 2020
@pirj @JonRowe
Add Ruby 2.7 to build matrix (#2271)
c547d16 
* Add Ruby 2.7 to build matrix
* Increase formatted output length

Co-authored-by: Jon Rowe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoittgt benoittgt benoittgt approved these changes

@JonRowe JonRowe JonRowe approved these changes

Assignees

@pirj pirj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pirj @JonRowe @benoittgt