Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats - gamestats/gameinfo does not have clear handling of full holds #369

Closed
donkz opened this issue Oct 4, 2021 · 1 comment
Closed
Assignees
Labels
bug Something isn't working Ready for testing Work has been done, ready to be tested so it can be closed
Milestone

Comments

@donkz
Copy link

donkz commented Oct 4, 2021

Describe the bug
round 1 does not always have a winner (not necessary)
round 2 winner should be Axis, Allied, or draw

To Reproduce
check stats for full hold matches , they would say Allies on ice or Axis on cypher.

Expected behavior
It is possible for a human to infer a winner - if the r2 timelimit ~ map limit and r2 winner is defense - then draw
It would be better if Round2 winner was displayed as Axis, Allied, or Draw

Screenshots or videos
This is not map specific.
ice
Gamelog: https://rtcwproapi.donkanator.com/gamelogs/16331547262
Gameinfo https://rtcwproapi.donkanator.com/matches/16331547262 - winner is allied . timelimit was 10 (r1 full hold) and no obj Capture.
cypher
Gamelog: https://rtcwproapi.donkanator.com/gamelogs/16331436612
Gameinfo https://rtcwproapi.donkanator.com/matches/16331436612 - winner is axis. timelimit was 10 (r1 full hold) and no obj Capture.

Additional context
Add any other context about the problem here.

@donkz donkz added the bug Something isn't working label Oct 4, 2021
@wolf6542
Copy link
Collaborator

wolf6542 commented Oct 4, 2021

I've also noticed some times console will report clock wrongly. Could be related.

shot0000

@krazykaze81 krazykaze81 added this to the 1.2.6 milestone Dec 3, 2021
@krazykaze81 krazykaze81 modified the milestones: 1.2.7, 1.2.8 Apr 2, 2022
@krazykaze81 krazykaze81 modified the milestones: 1.2.8, Backlog Dec 15, 2022
@krazykaze81 krazykaze81 added the Ready for testing Work has been done, ready to be tested so it can be closed label Jan 16, 2023
@krazykaze81 krazykaze81 moved this to In Progress in 1.2.9 Jan 16, 2023
@krazykaze81 krazykaze81 moved this from In Progress to Done in 1.2.9 Jan 16, 2023
@krazykaze81 krazykaze81 modified the milestones: Backlog, 1.2.9 Apr 24, 2023
@krazykaze81 krazykaze81 self-assigned this May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Ready for testing Work has been done, ready to be tested so it can be closed
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants