-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infinite Loop Between Minitest/EmptyLineBeforeAssertionMethods and Layout/EmptyLinesAroundClassBody #196
Comments
krishanbhasin-shopify
pushed a commit
to krishanbhasin-shopify/rubocop-minitest
that referenced
this issue
Nov 9, 2022
Addresses rubocop#196 Fix a false positive when using an assertion method as the first line within a test block Co-authored-by: Ryan Quanz <[email protected]>
8 tasks
krishanbhasin-shopify
pushed a commit
to krishanbhasin-shopify/rubocop-minitest
that referenced
this issue
Nov 9, 2022
…Methods\` Addresses rubocop#196 Fix a false positive when using an assertion method as the first line within a test block Co-authored-by: Ryan Quanz <[email protected]>
krishanbhasin-shopify
pushed a commit
to krishanbhasin-shopify/rubocop-minitest
that referenced
this issue
Nov 9, 2022
…Methods\` Addresses rubocop#196 Fix a false positive when using an assertion method as the first line within a test block Co-authored-by: Ryan Quanz <[email protected]>
krishanbhasin-shopify
pushed a commit
to krishanbhasin-shopify/rubocop-minitest
that referenced
this issue
Nov 9, 2022
…Methods\` Addresses rubocop#196 Fix a false positive when using an assertion method as the first line within a test block Co-authored-by: Ryan Quanz <[email protected]>
krishanbhasin-shopify
pushed a commit
to krishanbhasin-shopify/rubocop-minitest
that referenced
this issue
Nov 9, 2022
…ethods` Addresses rubocop#196 Fix a false positive when using an assertion method as the first line within a test block Co-authored-by: Ryan Quanz <[email protected]>
krishanbhasin-shopify
pushed a commit
to krishanbhasin-shopify/rubocop-minitest
that referenced
this issue
Nov 9, 2022
…ethods` Addresses rubocop#196 Fix a false positive when using an assertion method as the first line within a test block Co-authored-by: Ryan Quanz <[email protected]>
krishanbhasin-shopify
pushed a commit
to krishanbhasin-shopify/rubocop-minitest
that referenced
this issue
Nov 11, 2022
…ethods` Addresses rubocop#196 Fix a false positive when using an assertion method as the first line within a test block Co-authored-by: Ryan Quanz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior
When linting a minitest class whose first test only contains an assertion,
Minitest/EmptyLineBeforeAssertionMethods
should not try to insert an empty line above the test method as this violatesLayout/EmptyLinesAroundClassBody
. The following should be valid:Actual behavior
Minitest/EmptyLineBeforeAssertionMethods
autocorrects to:Steps to reproduce the problem
Try linting the class from expected behaviour.
RuboCop version
The text was updated successfully, but these errors were encountered: