Fix a false positive for Minitest/EmptyLineBeforeAssertionMethods
#197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishanbhasin-shopify
force-pushed
the
master
branch
4 times, most recently
from
a3ab098 to
8d3c8b6
Compare
krishanbhasin-shopify
changed the title
Minitest/EmptyLineBeforeAssertionMethods\Minitest/EmptyLineBeforeAssertionMethods
krishanbhasin-shopify
force-pushed
the
master
branch
from
8d3c8b6 to
e95a103
Compare
koic
reviewed
Nov 11, 2022
lib/rubocop/cop/minitest/empty_line_before_assertion_methods.rb
Outdated
Show resolved
Hide resolved
koic
reviewed
Nov 11, 2022
changelog/fix_false_positive_for_minitest_empty_line_before_assertion_methods.md
Outdated
Show resolved
Hide resolved
…ethods` Addresses rubocop#196 Fix a false positive when using an assertion method as the first line within a test block Co-authored-by: Ryan Quanz <[email protected]>
krishanbhasin-shopify
force-pushed
the
master
branch
from
e95a103 to
8802a80
Compare
|
Thanks! |
|
RuboCop Minitest 0.23.2 has been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Ryan Quanz [email protected]
Fixes #196
Minitest/EmptyLineBeforeAssertionMethodsexpectedtestblocks where the first line contained an assertion to have a newline above them. This isn't desired when, for example, the test is at the top of a class.This PR fixes a false positive for
Minitest/EmptyLineBeforeAssertionMethodswhen using an assertion method as the first line within a test block.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.