Enable InternalAffairs/CopEnabled cop

Since #490 made RuboCop 1.72+ a runtime requirement, `cop_enabled?` can now be used.
rubocop · Feb 18, 2025 · 197472c · 197472c
1 parent 73fecfd
commit 197472c
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 22 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -6,12 +6,6 @@
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-InternalAffairs/CopEnabled:
-  Exclude:
-    - 'lib/rubocop/cop/performance/inefficient_hash_search.rb'
-
 # Offense count: 12
 InternalAffairs/NodeDestructuring:
   Exclude:

diff --git a/lib/rubocop/cop/performance/inefficient_hash_search.rb b/lib/rubocop/cop/performance/inefficient_hash_search.rb
@@ -84,8 +84,7 @@ def current_method(node)
         end
 
         def use_long_method
-          preferred_config = config.for_all_cops['Style/PreferredHashMethods']
-          preferred_config && preferred_config['EnforcedStyle'] == 'long' && preferred_config['Enabled']
+          config.for_enabled_cop('Style/PreferredHashMethods')['EnforcedStyle'] == 'long'
         end
 
         def correct_argument(node)

diff --git a/spec/rubocop/cop/performance/inefficient_hash_search_spec.rb b/spec/rubocop/cop/performance/inefficient_hash_search_spec.rb
@@ -138,28 +138,24 @@ def my_include?(key)
   end
 
   context 'when config specifies long hash methods but is not enabled' do
-    let(:config) do
-      RuboCop::Config.new(
-        'AllCops' => {
-          'Style/PreferredHashMethods' => {
-            'EnforcedStyle' => 'long', 'Enabled' => false
-          }
+    let(:other_cops) do
+      {
+        'Style/PreferredHashMethods' => {
+          'EnforcedStyle' => 'long', 'Enabled' => false
         }
-      )
+      }
     end
 
     it_behaves_like 'correct behavior', :short
   end
 
   context 'when config enforces long hash methods' do
-    let(:config) do
-      RuboCop::Config.new(
-        'AllCops' => {
-          'Style/PreferredHashMethods' => {
-            'EnforcedStyle' => 'long', 'Enabled' => true
-          }
+    let(:other_cops) do
+      {
+        'Style/PreferredHashMethods' => {
+          'EnforcedStyle' => 'long', 'Enabled' => true
         }
-      )
+      }
     end
 
     it_behaves_like 'correct behavior', :long