Pluginfy RuboCop Performance #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
pluginfy_with_lint_roller
branch
from
a45b18d to
1659a68
Compare
8 tasks
koic
force-pushed
the
pluginfy_with_lint_roller
branch
4 times, most recently
from
87b14f8 to
63ec3ef
Compare
koic
force-pushed
the
pluginfy_with_lint_roller
branch
2 times, most recently
from
bfd90d6 to
a473e49
Compare
This PR adds support for RuboCop's Plugin feature: rubocop/rubocop#13792 It replaces the ad-hoc `Inject` with RuboCop plugins introduced in RuboCop 1.72. NOTE: Version 1.72.1 or later is specified, as it includes rubocop/rubocop#13837, which removes the `Inject` from spec_helper.rb. While 1.72.0 is sufficient for runtime, but specifying the patch version 1.72.1 keeps things simple.
koic
force-pushed
the
pluginfy_with_lint_roller
branch
from
a473e49 to
b83339d
Compare
6 tasks
koic
added a commit
that referenced
this pull request
Feb 18, 2025
Since #490 made RuboCop 1.72+ a runtime requirement, `cop_enabled?` can now be used.
This was referenced Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for RuboCop's Plugin feature:
rubocop/rubocop#13792
It replaces the ad-hoc
Injectwith RuboCop plugins introduced in RuboCop 1.72.NOTE: Version 1.72.1 or later is specified, as it includes rubocop/rubocop#13837, which removes the
Injectfrom spec_helper.rb. While 1.72.0 is sufficient for runtime, but specifying the patch version 1.72.1 keeps things simple.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.