Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve core/stdlib signature coverage #1

Open
soutaro opened this issue Apr 18, 2019 · 10 comments
Open

Improve core/stdlib signature coverage #1

soutaro opened this issue Apr 18, 2019 · 10 comments
Labels
good first issue Good for newcomers

Comments

@soutaro
Copy link
Member

soutaro commented Apr 18, 2019

We provide the signatures of a very limited number of standard library classes. We will really appreciate if you write the signature of other classes.

(Note that we are currently working for standard library signatures.)

@soutaro soutaro added the good first issue Good for newcomers label Apr 18, 2019
@connorshea
Copy link
Contributor

Sorbet already has type signatures for a lot of the stdlib, have you considered writing something to transform their files into ruby-signature-compatible files to automate this process?

https://github.com/sorbet/sorbet/tree/master/rbi/core

@soutaro
Copy link
Member Author

soutaro commented Jul 1, 2019

Yes, it should be one of the best ways to improve the coverage. I haven't tried yet.

@connorshea
Copy link
Contributor

I know this ended up partially happening in #23, do we have any way of tracking progress for stdlib coverage? Essentially code coverage for type signatures. :)

@soutaro
Copy link
Member Author

soutaro commented Jan 8, 2020

I have a guide for contributions at https://github.com/ruby/ruby-signature/blob/master/docs/CONTRIBUTING.md . Could you check it? Tell me if you have any questions or feedback.

@connorshea
Copy link
Contributor

For a lot of the libraries in the spreadsheet, we should be able to get the signatures from Sorbet e.g. for csv or benchmark.

@soutaro
Copy link
Member Author

soutaro commented Jan 12, 2020

Yes, it should be a good option to start having an initial version. However, I believe we need to review and revise them ourselves anyway.

@gaurav2699
Copy link

Hey, is this issue still open? I would like to work on this issue.

@snaka
Copy link
Contributor

snaka commented Jan 22, 2022

Hi.
It seems that @gaurav2699 's question hasn't been answered until now, so I'd like to make sure.

Is it correct that this issue is still active?

Also, have you already implemented the idea of importing the sorbet type definition file?

I'm hesitant to start a contribution because I personally can't read the status of this issue.

Thank you for your time.

@snaka
Copy link
Contributor

snaka commented Jan 25, 2022

I' ve read the code and the PR, and it seems to be still open, so I'll try to help as much as I can.
Thank you very much.

Also, have you already implemented the idea of importing the sorbet type definition file?

It seems to have been addressed in the following PR 👍

#24

@snaka
Copy link
Contributor

snaka commented Feb 6, 2022

I thought it would be better to change the title of this issue to "core and standard library".

Reference : #876

@soutaro soutaro changed the title Improve standard library signature coverage Improve core/stdlib signature coverage Feb 7, 2022
This was referenced Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Development

No branches or pull requests

4 participants