Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signature and tests for Encoding::*Error #898

Merged
merged 2 commits into from
Feb 7, 2022
Merged

Signature and tests for Encoding::*Error #898

merged 2 commits into from
Feb 7, 2022

Conversation

snaka
Copy link
Contributor

@snaka snaka commented Feb 6, 2022

Reference: #1

@snaka snaka changed the title Signature and tests for Encoding::InvalidByteSequenceError Signature and tests for Encoding::InvalidByteSequenceError and Encoding::UndefinedConversionError Feb 6, 2022
@snaka snaka changed the title Signature and tests for Encoding::InvalidByteSequenceError and Encoding::UndefinedConversionError Signature and tests for Encoding::*Error Feb 6, 2022
@snaka snaka marked this pull request as ready for review February 6, 2022 10:41
soutaro
soutaro approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 💪

@soutaro soutaro merged commit e5f0541 into ruby:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snaka @soutaro