Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated from Sorbet RBI #24

Merged
merged 6 commits into from
Sep 10, 2019
Merged

Generated from Sorbet RBI #24

merged 6 commits into from
Sep 10, 2019

Conversation

soutaro
Copy link
Member

@soutaro soutaro commented Aug 20, 2019

Automatically translated type signatures.

Probably we need to edit the signatures a lot. Several known mismatches.

  • T::Boolean or bool
  • BasicObject or any
  • Sometimes block type is marked T.unknown
  • Enumerable takes only one type argument.

Anyway, we should review the output carefully.

@soutaro
Copy link
Member Author

soutaro commented Aug 21, 2019

Class/module type parameter handling looks broken. 😢

@soutaro soutaro marked this pull request as ready for review September 10, 2019 06:57
@soutaro
Copy link
Member Author

soutaro commented Sep 10, 2019

Merging this to make the auto-generated signature the starting point to make collaboration.

@soutaro soutaro merged commit 51ad761 into master Sep 10, 2019
@soutaro soutaro deleted the sorbet-rbi branch September 10, 2019 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants