Fix rbs_extension build on Windows #963
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 2.3.0 is [failing] on Windows CI for ruby/ruby because Visual Studio 2015 does not support the -Wold-style-definition flag. Check for MSVC with mkmf using its predefined [macro]. [macro]: https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-140 [failing]: https://ci.appveyor.com/project/ruby/ruby/builds/43108024/job/lqdka0uxpqbudah9#L2861
nobu
reviewed
Apr 3, 2022
| @@ -1,4 +1,4 @@ | |||
| require 'mkmf' | |||
| $INCFLAGS << " -I$(top_srcdir)" if $extmk | |||
| $CFLAGS += " -std=c99 -Wold-style-definition" | |||
| $CFLAGS += " -std=c99 -Wold-style-definition" unless have_macro('_MSC_VER') | |||
There was a problem hiding this comment.
Not all compilers other than MSVC accept gcc options.
Suggested change
| $CFLAGS += " -std=c99 -Wold-style-definition" unless have_macro('_MSC_VER') | |
| append_cflags(%w"-std=c99 -Wold-style-definition") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 2.3.0 is failing on Windows CI for ruby/ruby because
Visual Studio 2015 does not support the -Wold-style-definition flag.
Check for MSVC with mkmf using its predefined macro.
Testing upstream at ruby/ruby#5752