Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mswin build, use append_cflags, add Windows 'compile only' CI #964

Merged
merged 2 commits into from
Apr 4, 2022
Merged

Fix mswin build, use append_cflags, add Windows 'compile only' CI #964

merged 2 commits into from
Apr 4, 2022

Conversation

MSP-Greg
Copy link
Contributor

@MSP-Greg MSP-Greg commented Apr 2, 2022

With ruby-loco's mswin make install, the following error is thrown:

cl : Command line error D8021 : invalid numeric argument '/Wold-style-definition'

@MSP-Greg
Copy link
Contributor Author

MSP-Greg commented Apr 3, 2022 •
edited
Loading

Similar to PR #963...

@XrXr Sorry I missed your PR, frustrating day.

@MSP-Greg MSP-Greg force-pushed the fix-mswin branch 2 times, most recently from 862c19f to f7a19b2 Compare April 3, 2022 13:45
@MSP-Greg
Fix mswin build, use append_cflags
5462d69 
Throws:
```
cl : Command line error D8021 : invalid numeric argument '/Wold-style-definition'
```

Update extconf.rb

Update extconf.rb
@MSP-Greg MSP-Greg changed the title Fix Windows mswin bulld Fix mswin build, use append_cflags Apr 3, 2022
@MSP-Greg
Copy link
Contributor Author

MSP-Greg commented Apr 3, 2022

Sorry. Not enough coffee yet.

@MSP-Greg
Copy link
Contributor Author

MSP-Greg commented Apr 3, 2022 •
edited
Loading

I added a commit which adds Windows CI using ucrt and mswin, only checking for successful compile. In my fork, the jobs failed for the mswin builds when the first commit wasn't included.

@MSP-Greg MSP-Greg changed the title Fix mswin build, use append_cflags Fix mswin build, use append_cflags, add Windows 'compile only' CI Apr 3, 2022
soutaro
soutaro approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MSP-Greg Thank you! 🎉

@soutaro soutaro merged commit 53e7470 into ruby:master Apr 4, 2022
@soutaro soutaro mentioned this pull request Apr 4, 2022
Closed
@MSP-Greg MSP-Greg deleted the fix-mswin branch April 4, 2022 14:34
@MSP-Greg
Copy link
Contributor Author

MSP-Greg commented Apr 4, 2022

@soutaro

Thanks for merging. Re testing, `stackprof' won't install on any Windows version.

With that guarded in the Gemfile, tests pass locally on my system with mingw/ucrt master builds. I have gdbm libraries installed, but the Actions Windows image doesn't. Windows mswin has never been built with gdbm.

So, testing bottom line is that mingw and/or ucrt testing can be done, but not mswin. Not sure if it should be added. If you want to add it, it's a small PR...

Also, a small problem with bundled extension gems. They are downloaded and installed/compiled all within the make install step. So, packagers (like ruby-loco's master builds) can't patch them before compile. Hence, the issue that this fixes causes the Actions' mswin build to be locked to the last successful build before the 2.3.0 release. Everyone's busy, but I thought I'd mention it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MSP-Greg @soutaro