add spec for Dir.glob / Dir.[] result being sorted by default #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eregon
reviewed
Oct 7, 2021
core/dir/shared/glob.rb
Outdated
| end | ||
|
|
||
| it "result is sorted by default" do | ||
| Dir.send(@method,'*').should == @sorted_files |
There was a problem hiding this comment.
Suggested change
| Dir.send(@method,'*').should == @sorted_files | |
| Dir.send(@method, '*').should == @sorted_files |
eregon
reviewed
Oct 7, 2021
core/dir/shared/glob.rb
Outdated
| @@ -38,6 +38,32 @@ | |||
| end | |||
| end | |||
|
|
|||
| ruby_version_is "3.0" do | |||
| before :each do | |||
| @sorted_files = %w[ | |||
There was a problem hiding this comment.
It's better to just get the result and then result.should == results.sort.
That way we don't hardcode filenames here, could you do that?
|
We could add It seems on Linux at least files aren't sorted, but they might luckily still be in sorted order so I don't think we can test that. |
lxxxvi
force-pushed
the
dir-glob-sorts-result-by-default
branch
from
d2c11ad to
e28eb3d
Compare
|
@eregon Thank you for your feedback, I pushed the changes you suggested. 👍 |
eregon
reviewed
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
From #823 :
I am not sure if or how to add a spec for
sorted: false. As far as I understand the result may or may not differ depending on OS. Is there a reliable/deterministic sorting logic behindsorted: false?