Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add spec for Dir.glob / Dir.[] result being sorted by default #861

Merged
merged 2 commits into from
Oct 8, 2021
Merged

add spec for Dir.glob / Dir.[] result being sorted by default #861

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e28eb3d
replace fix values
lxxxvi Oct 7, 2021
ec54084
Update core/dir/shared/glob.rb
eregon Oct 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions core/dir/shared/glob.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,23 @@
end
end

ruby_version_is "3.0" do
it "result is sorted by default" do
result = Dir.send(@method, '*')
result.should == result.sort
end

it "result is sorted with sort: true" do
result = Dir.send(@method, '*', sort: true)
result.should == result.sort
end

it "sort: false returns same files" do
result = Dir.send(@method,'*', sort: false)
result.sort.should == Dir.send(@method, '*').sort
end
end

it "matches non-dotfiles with '*'" do
expected = %w[
brace
Expand Down