text: Set autosize bounds lazily #18870
Merged
+2,292
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
text
|
Can you also please test #11632 on this? |
adrian17
reviewed
Dec 13, 2024
| @@ -1,12 +1,12 @@ | |||
| 150 | |||
| 103 | |||
There was a problem hiding this comment.
was the old test output created wrongly?
It the new one equal to FP?
There was a problem hiding this comment.
That's correct. Somehow the output.txt wasn't from FP
adrian17
approved these changes
Dec 13, 2024
kjarosh
force-pushed
the
autosize-lazy-bounds
branch
from
b02f874 to
3359966
Compare
|
To be sure, is anything blocking this? |
|
One test fails due to #18861 missing |
The pixel bounds returned by Transform behave sometimes differently compared to regular bounds.
This simplifies setting bounds, as it doesn't require a gc context. This is especially helpful when setting the bounds lazily after autosize.
Auto size does not set the bounds immediately, but lazily after some selected operations, independently of relayout. This patch removes the `requested_width/height` and replaces it with proper lazily set autosize bounds.
This test verifies when lazy autosize bounds are applied taking into consideration various interactions with other objects and classes.
This test verifies lazy autozise bounds behavior in relation to various events.
kjarosh
force-pushed
the
autosize-lazy-bounds
branch
from
3359966 to
d143fb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TextField.getCharIndexAtPointaccurate #18861Auto size does not set the bounds immediately, but lazily after some selected operations, independently of relayout.
This patch removes the
requested_width/heightand replaces it with proper lazily set autosize bounds.Some tests are added which prove that relayout and lazy autosize bounds are independent of each other, and prove when autosize bounds are lazily updated.