-
-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
text: Lazily layout text #7749
Closed
Closed
text: Lazily layout text #7749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Herschel
force-pushed
the
lazy-text-layout
branch
from
August 25, 2022 06:32
7d6903c
to
09c8f6c
Compare
This will allow us to lazily recalculate the text layout at render time.
Herschel
force-pushed
the
lazy-text-layout
branch
from
August 25, 2022 06:41
09c8f6c
to
f1f60bc
Compare
danielhjacobs
added
A-core
Area: Core player, where no other category fits
T-perf
T-perf
Type: Performance Improvements
and removed
T-perf
labels
Sep 17, 2024
Superseded by #18870. We still could do lazy layout, but strictly for performance reasons and it would look a lot different anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #7735, reflow text lazily instead of every time a text parameter is changed.
When a text field property is modified (such as changing the text or font size), Flash marks the text layout as dirty. The layout is then recalculated lazily when the textfield is rendered, or when a value that depends on the layout is accessed via ActionScript.
RenderContext::gc_context
to allow mutating theEditText
during render.RenderContext
.LayoutContext
to only require theLibrary
instead of a fullUpdateContext
.text
,autoSize
,_width
marks the layout as dirty.This is more efficient and necessary for accuracy, as the layout will be calculated at different times depending on the order of property access.
TODO:
_width
/_height
if autosize is disabled.scroll
, etc.)EditText
bools.redraw_border
?